settings: guard the theme editor's sidebar reachability - #22
Open
antonarnaudov wants to merge 1 commit into
Open
settings: guard the theme editor's sidebar reachability#22antonarnaudov wants to merge 1 commit into
antonarnaudov wants to merge 1 commit into
Conversation
The reported "colour-wheel editor is unreachable" repro was against an old
installed build (v0.1.0), where "Create your own custom theme" was a README
link that opened a browser and the editor had no sidebar entry. That's already
fixed on main / v0.2.9: the Appearance page points at the sidebar, and the
nav lists CustomizeUi, ThemeGallery ("Explore themes"), and ThemeCreator
("Create your own custom theme") → the ThemeCreatorPageView with the colour
wheel. No functional change is needed.
To keep it that way, extract the sidebar nav list into a pure `base_nav_items()`
and add a regression test asserting the theme editor, theme gallery, and
Customize UI each keep a sidebar entry — so the in-app entry point can't be
dropped again in a refactor.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR — the reported bug is a stale install, not a v0.2.9 regression
A bug report said the Photoshop-style colour-wheel theme editor is unreachable in "v0.2.9": clicking Settings → Appearance → "Create your own custom theme" opens the browser instead of navigating in-app, and the "+" only opens the image modal.
That repro was against an old installed build (
v0.1.0) — confirmed via the installed app'sInfo.plist(CFBundleShortVersionString = 0.1.0). In v0.1.0 that link was a README hyperlink (open_url→ browser) and the sidebar had no theme sections.It's already fixed on
main/ v0.2.9:appearance_page.rsno longer renders a link — it shows text pointing at the sidebar.nav_itemslist includesCustomizeUi,ThemeGallery("Explore themes"), andThemeCreator("Create your own custom theme") →ThemeCreatorPageView, hostingThemeCreatorBodywith the full hue/saturation/value colour wheel.build_nav_stops— noopen_urlin that path.So no functional fix is needed; users on v0.1.0 just need to update.
What this PR does
Adds the regression guard requested in the report, so the in-app entry point can't be silently dropped again:
base_nav_items()(no behavior change — the builder just calls it, then applies the existingWarpControlCliinsert).theme_editor_and_gallery_are_reachable_from_the_sidebarassertingThemeCreator,ThemeGallery, andCustomizeUieach keep a sidebar entry.Verified locally
cargo check -p warp --tests— compiles clean.cargo test -p warp settings_view::tests::theme_editor_and_gallery_are_reachable_from_the_sidebar— 1 passed.🤖 Generated with Claude Code