Repository navigation
chore(metrics): Collect test metric to validate sleep clock drift fix - #127562
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
Lms24
marked this pull request as ready for review
October 15, 2026 16:00
Emitting on page load can't catch drift, since the clock only drifts after the tab has been open across a sleep. Emit on every click on an issue row instead. Co-Authored-By: Claude <noreply@anthropic.com>
billyvg
approved these changes
Oct 15, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test metric that I don't plan on keeping around for the long run. SDK version 11.6.0 shipped a fix to detect and correct clock drift on telemetry timestamps when devices go to sleep.
When we emitted a new metric a while ago, we saw a bunch of metric emissions happening much earlier than that metric was even deployed. This PR aims to repeat this to validate that the SDK no longer emits such early timestamps.
Best to test this with actual users' browsers, since sleep drift varies greatly across devices.
If reviewers have too many concerns with this, let me know, otherwise, I'd plan to remove this after a day of testing. The metric is emitted when clicking an issue on the issues feed, since it's one of the most visited pages and clicks can happen long after page load (e.g. after the device woke up), unlike emitting on page load.