Skip to content

ref(inbox): use new issue-inbox flag on backend - #122421

Merged
malwilley merged 1 commit into
masterfrom
malwilley/use-issue-inbox-flag-v1
Aug 24, 2026
Merged

ref(inbox): use new issue-inbox flag on backend#122421
malwilley merged 1 commit into
masterfrom
malwilley/use-issue-inbox-flag-v1

Conversation

@malwilley

Copy link
Copy Markdown
Member

#122110 must be merged and deployed first

Drops issue-stream-progress-ui for the new issue-inbox flag

@malwilley
malwilley requested a review from a team as a code owner August 21, 2026 21:02
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 21, 2026
manager.add("organizations:issue-summary-experimental", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
# Enable new issue stream progress views
manager.add("organizations:issue-stream-progress-ui", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
# Show the "recommended" sort as an option in the issue stream sort dropdown

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Removing the issue-stream-progress-ui feature flag will cause the inbox page to render a NotFound error because the frontend still relies on this flag to render.
Severity: CRITICAL

Suggested Fix

This change has a deployment dependency on a frontend pull request. Ensure the frontend PR, which removes the dependency on the issue-stream-progress-ui flag, is merged and deployed before this backend change. Alternatively, coordinate the deployment of both PRs to happen simultaneously to avoid breaking the inbox page.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: src/sentry/features/temporary.py#L382

Potential issue: The pull request removes the backend registration for the
`organizations:issue-stream-progress-ui` feature flag. However, the frontend code in
`static/app/views/issueList/pages/inbox.tsx` checks for the presence of this flag to
render the inbox page. If this backend change is deployed before the corresponding
frontend change that removes this check, the condition
`organization.features.includes('issue-stream-progress-ui')` will always be false. This
will cause the component to return a `NotFound` page, making the entire inbox feature
inaccessible to all users.

Also affects:

  • static/app/views/issueList/pages/inbox.tsx:151

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is expected, the other PR changes the frontend pieces

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d3e3743. Configure here.

Comment thread src/sentry/notifications/platform/templates/activity/base.py
@malwilley
malwilley requested a review from leeandher August 24, 2026 15:48
@malwilley malwilley changed the title ref(inbox): use issue inbox flag for activity links ref(inbox): use new issue-inbox flag on backend Aug 24, 2026
@malwilley
malwilley merged commit 8e18ace into master Aug 24, 2026
90 checks passed
@malwilley
malwilley deleted the malwilley/use-issue-inbox-flag-v1 branch August 24, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants