fix(api): Reject negative pagination cursors - #122411
Open
cvxluo wants to merge 1 commit into
Open
Conversation
GenericOffsetPaginator passed negative offsets to backend callbacks, where query builders could raise internal errors. Reject them with the shared pagination error so API endpoints return 400 consistently. Fixes SENTRY-5TES Co-authored-by: Codex <noreply@openai.com>
github-actions
Bot
added
the
Scope: Backend
cvxluo
marked this pull request as ready for review
August 21, 2026 18:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If users pass in negative cursors, we raise a 500 rather than a 400. We should validate this so we raise a 400.
Fixes SENTRY-5TES