Skip to content

Draft: Remove catchall endpoint from mypy weaklist#117520

Draft
cursor[bot] wants to merge 1 commit into
masterfrom
cursor/untyped-module-cleanup-9c5a
Draft

Draft: Remove catchall endpoint from mypy weaklist#117520
cursor[bot] wants to merge 1 commit into
masterfrom
cursor/untyped-module-cleanup-9c5a

Conversation

@cursor

@cursor cursor Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove sentry.api.endpoints.catchall from the mypy weaklist in pyproject.toml
  • add explicit annotations for *args/**kwargs in CatchallEndpoint.dispatch
  • keep endpoint behavior unchanged while making the module compatible with strong typing settings

Testing

  • .venv/bin/mypy --config-file pyproject.toml src/sentry/api/endpoints/catchall.py
  • .venv/bin/prek run -q --files src/sentry/api/endpoints/catchall.py pyproject.toml
  • SENTRY_MYPY_PRE_PUSH=1 .venv/bin/prek run -q mypy --files src/sentry/api/endpoints/catchall.py --stage pre-push
  • attempted: .venv/bin/pytest -n3 -svv --reuse-db tests/sentry/api/endpoints/test_catchall.py (blocked by missing local Redis/Docker in this VM)

Review

@armenzg please review.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Open in Web View Automation 

Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 12, 2026
@getsantry

getsantry Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry Bot added the Stale label Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant