Repository navigation
fix(sourcemaps): Quote arguments in generated Wrangler scripts - #1364
Merged
Merged
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
msonnb
marked this pull request as ready for review
October 8, 2026 10:41
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrangler source map setup reuses the extracted
--outdirvalue in a generated shell command. Previously, a quoted literal directory containing shell syntax could be evaluated when the upload script ran.Safely quote generated directory, strip-prefix, self-hosted URL, organization, and project arguments, and quote release variable references. Add shell-execution regressions for both
--outdirforms, a normal-path control, and embedded quotes and command substitution. Update the E2E script expectations to match the newly quoted arguments.Fixes WIZARD-148.