Repository navigation
Replace deprecated Sentry.captureFeedback calls on Android - #1646
Merged
Merged
Conversation
Co-Authored-By: Nelson Osacky <nelson.osacky@sentry.io>
Co-Authored-By: Nelson Osacky <nelson.osacky@sentry.io>
runningcode
marked this pull request as ready for review
October 22, 2026 11:38
tustanivsky
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sentry-java v9 removes the deprecated
Sentry.captureFeedback(...)overloads (getsentry/sentry-java#6337). The replacement,Sentry.feedback().capture(...), already exists in the 8.x version we bundle, so we can switch now, ahead of the v9 bump.The Android bridge had two call sites:
SentryBridgeJava.captureFeedbackWithScopecalledSentry.captureFeedback(feedback, hint, callback). Against v9 this would fail to compile.FAndroidSentrySubsystem::CaptureFeedbackcalled the staticSentry.captureFeedback(Feedback, Hint)directly over JNI. Against v9 this would compile fine and then fail at runtime with a missing method. It now goes through a newSentryBridgeJava.captureFeedbackhelper, which callsSentry.feedback().capture(feedback, hint). That way we don't need to add a JNI class ref forIFeedbackApi.The bridge never used the removed
showUserFeedbackDialog/SentryUserFeedbackDialogAPIs, so nothing changes there.via no.
--
View Junior Session [Sentry]