Repository navigation
Release discarded value in native before* callbacks - #1536
Merged
Merged
Conversation
The before_send, before_breadcrumb, before_log, and before_metric callbacks returned sentry_value_new_null() without decref-ing the incoming value when a handler drops an item. sentry-native transfers ownership of the value to the callback and does not free it on a null return, so each dropped item leaked one sentry_value_t. Decref the value before returning null, matching the existing before_send_feedback handler.
jpnurmi
approved these changes
Aug 13, 2026
JoshuaMoelans
approved these changes
Aug 13, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a memory leak in the
sentry-nativebefore*callback handlers.On
sentry-nativeplatforms,before_send,before_breadcrumb,before_log, andbefore_metricreturnedsentry_value_new_null()without releasing the incomingsentry_value_twhen a handler drops an item. The SDK core transfers ownership to the callback and does not free the value on a null return, so each dropped item leaked one native value.The fix is to decref before returning null in the four handlers, matching the already-correct
OnBeforeSendFeedback(#1528). The wrappers never decref, so this is the only release on the drop path (no double-free).Only affects
sentry-nativebackends, only when a handler returnsnullto discard.Closes #1529