Skip to content

test: enable app-hang tracking only in the App Hang integration test #2899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bitsandfoxes wants to merge 1 commit into
base: chore/ci-fail-fast
Choose a base branch
from
Draft

test: enable app-hang tracking only in the App Hang integration test #2899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/Scripts.Integration.Test/Scripts/IntegrationOptionsConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ public override void Configure(SentryUnityOptions options)
options.DisableAnrIntegration();
#pragma warning restore CS0618 // Type or member is obsolete

// App Hang tracking
options.EnableAppHangTracking = true;
// Only for the app hang test: on a slow device the 2s watchdog fires in the other tests too, and the hang event carries their tags.
options.EnableAppHangTracking = IntegrationTester.GetTestArg() == "app-hang-capture";
options.AppHangTimeout = TimeSpan.FromSeconds(2);

// Runtime initialization for integration tests
Expand Down
4 changes: 2 additions & 2 deletions test/Scripts.Integration.Test/Scripts/IntegrationTester.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@ public void Start()
#if UNITY_IOS && !UNITY_EDITOR
// .NET `Environment.GetCommandLineArgs()` doesn't seem to work on iOS so we get the test arg in Objective-C
[DllImport("__Internal", EntryPoint="getTestArgObjectiveC")]
private static extern string GetTestArg();
internal static extern string GetTestArg();
#else
private static string GetTestArg()
internal static string GetTestArg()
{
string arg = null;
#if UNITY_EDITOR
Expand Down
Loading