Repository navigation
fix(core): Do not mark sendDefaultPii as deprecated in React Native options - #6864
Merged
Merged
Conversation
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Contributor
alwx
marked this pull request as ready for review
October 12, 2026 11:58
antonis
approved these changes
Oct 12, 2026
…ptions ReactNativeOptions and ReactNativeClientOptions now omit sendDefaultPii from the @sentry/core options. TypeScript then uses the declaration from BaseReactNativeOptions, which is not deprecated. Fixes #6830 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alwx
force-pushed
the
alwx/bugfix/6830
branch
from
October 12, 2026 14:32
40b6359 to
5e9d94f
Compare
alwx
enabled auto-merge (squash)
October 12, 2026 14:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
ReactNativeOptionsandReactNativeClientOptionsnow omitsendDefaultPiifrom the@sentry/coreoptions. TypeScript then uses the declaration fromBaseReactNativeOptions, which is not deprecated.💡 Motivation and Context
Type-aware linters reported
sendDefaultPiias deprecated, but React Native hidesdataCollectionand tells users to usesendDefaultPii. Fixes #6830.💚 How did you test it?
A TypeScript language service script showed two deprecation diagnostics on
sendDefaultPiibefore the change and none after it. The build, lint, circular dependency check, API report, and Jest tests pass.📝 Checklist
sendDefaultPIIis enabled.🤖 Generated with Claude Code