Skip to content

fix(core): Do not mark sendDefaultPii as deprecated in React Native options - #6864

Merged
alwx merged 2 commits into
mainfrom
alwx/bugfix/6830
Oct 12, 2026
Merged

alwx merged 2 commits into
mainfrom
alwx/bugfix/6830

Conversation

@alwx

@alwx alwx commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

ReactNativeOptions and ReactNativeClientOptions now omit sendDefaultPii from the @sentry/core options. TypeScript then uses the declaration from BaseReactNativeOptions, which is not deprecated.

💡 Motivation and Context

Type-aware linters reported sendDefaultPii as deprecated, but React Native hides dataCollection and tells users to use sendDefaultPii. Fixes #6830.

💚 How did you test it?

A TypeScript language service script showed two deprecation diagnostics on sendDefaultPii before the change and none after it. The build, lint, circular dependency check, API report, and Jest tests pass.

📝 Checklist

  • I added tests to verify changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.
  • No breaking changes.

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


  • fix(core): Do not mark sendDefaultPii as deprecated in React Native options by alwx in #6864
  • ci(ios): Archive the SwiftPM app to catch xcframework signature collisions by alwx in #6871
  • feat(core): Support applicationKey and moduleMetadata in Metro config by alwx in #6863
  • chore(deps): update JavaScript SDK to v10.76.2 by antonis in #6866
  • ci(core): Guard the "sideEffects": false contract with a lint check by antonis in #6836
  • chore(deps): bump nx from 22.7.7 to 22.7.12 by dependabot in #6857
  • chore(deps): bump compression from 1.7.5 to 1.8.2 by dependabot in #6856
  • chore(deps): bump postcss-selector-parser from 7.1.4 to 7.1.6 by dependabot in #6855
  • chore(deps): bump source-map-js from 1.2.1 to 1.2.2 by dependabot in #6854
  • chore(deps): bump proxy-addr from 2.0.7 to 2.0.8 by dependabot in #6853
  • chore(deps): bump handlebars from 4.7.9 to 4.7.10 by dependabot in #6862
  • chore(deps): update Wizard to v8.0.1 by github-actions in #6852

🤖 This preview updates automatically when you update the PR.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor
Fails
🚫 Pull request is not ready for merge, please add the "ready-to-merge" label to the pull request

Generated by 🚫 dangerJS against 5e9d94f

@alwx
alwx marked this pull request as ready for review October 12, 2026 11:58
@alwx
alwx requested review from a team, antonis and lucas-zimerman as code owners October 12, 2026 11:58
alwx and others added 2 commits October 12, 2026 16:32
…ptions

ReactNativeOptions and ReactNativeClientOptions now omit sendDefaultPii from
the @sentry/core options. TypeScript then uses the declaration from
BaseReactNativeOptions, which is not deprecated.

Fixes #6830

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@alwx
alwx force-pushed the alwx/bugfix/6830 branch from 40b6359 to 5e9d94f Compare October 12, 2026 14:32
@alwx
alwx enabled auto-merge (squash) October 12, 2026 14:35
@alwx
alwx merged commit 4f3e71a into main Oct 12, 2026
57 of 73 checks passed
@alwx
alwx deleted the alwx/bugfix/6830 branch October 12, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sendDefaultPii is reported as deprecated on ReactNativeOptions although dataCollection is hidden

2 participants