Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dev-packages/e2e-tests/maestro/utils/sentryApi.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ const RETRY_INTERVAL = 1000;
const requestHeaders = { 'Authorization': `Bearer ${sentryAuthToken}` }

function sleep(ms) {
// TODO reach out to Maestro & GrallJS via GitHub issues.
// Maestro's GraalJS runtime has no setTimeout/Promise, so instead of
// return new Promise(resolve => setTimeout(resolve, ms));
// Instead, we need to do a busy wait.
// we busy-wait.
const until = Date.now() + ms;
while (Date.now() < until) {
// console.log(`Sleeping for ${until - Date.now()} ms`);
Expand Down
8 changes: 4 additions & 4 deletions packages/core/ios/RNSentryStart.m
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,8 @@ + (SentryOptions *_Nullable)createOptionsWithDictionary:(NSDictionary *_Nonnull)

// Exclude Dev Server and Sentry Dsn request from Breadcrumbs
NSString *dsn = [self getURLFromDSN:[mutableOptions valueForKey:@"dsn"]];
// TODO: For Auto Init from JS dev server is resolved automatically, for init from options file
// dev server has to be specified manually
// devServerUrl is resolved by the JS layer on auto-init; for init from an options file it comes
// from the options instead (JS isn't available here to resolve it).
NSString *devServerUrl = [mutableOptions valueForKey:@"devServerUrl"];
sentryOptions.beforeBreadcrumb
= ^SentryBreadcrumb *_Nullable(SentryBreadcrumb *_Nonnull breadcrumb)
Expand Down Expand Up @@ -159,8 +159,8 @@ + (SentryOptions *_Nullable)createOptionsWithDictionary:(NSDictionary *_Nonnull)
sentryOptions.spotlightUrl = spotlightValue;
} else if ([spotlightValue isKindOfClass:[NSNumber class]]) {
sentryOptions.enableSpotlight = [spotlightValue boolValue];
// TODO: For Auto init from JS set automatically for init from options file have to be
// set manually
// defaultSidecarUrl is resolved by the JS layer on auto-init; for init from an options
// file it comes from the options instead.
id defaultSpotlightUrl = [mutableOptions valueForKey:@"defaultSidecarUrl"];
if (defaultSpotlightUrl != nil) {
sentryOptions.spotlightUrl = defaultSpotlightUrl;
Expand Down
2 changes: 1 addition & 1 deletion samples/expo/app/(tabs)/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export default function TabOneScreen() {
<Button
title="Unhandled Promise Rejection"
onPress={() => {
// TODO: No working in Expo Go App
// Not captured when running in Expo Go.
Promise.reject(new Error('Unhandled Promise Rejection'));
}}
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,18 +40,13 @@ describe('Capture app start crash', () => {
sdk: {
features: ['experimentalViewRenderer', 'dataSwizzling'],
integrations: [
// Only SessionReplay appears here, by design. App-start crashes are flushed
// synchronously by sentry-cocoa during SDK init, from inside SentryCrashIntegration,
// before the later integrations are added to the hub. sdk.integrations is computed
// from the live installed-integration list at send time, so it reflects only what is
// ordered before the crash integration (SessionReplay). Non-startup crashes are sent
// async after init completes and carry the full list. See #6845.
'SessionReplay',
// FIXME: Why are these not included?
// 'WatchdogTerminationTracking',
// 'Screenshot',
// 'Crash',
// 'ANRTracking',
// 'ViewHierarchy',
// 'AutoBreadcrumbTracking',
// 'AutoSessionTracking',
// 'NetworkTracking',
// 'AppStartTracking',
// 'FramesTracking',
],
name: 'sentry.cocoa.react-native',
packages: [
Expand Down
1 change: 0 additions & 1 deletion samples/react-native/e2e/utils/parseEnvelope.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ export function parseEnvelope(env: string | Uint8Array): Envelope {
const isBinaryAttachment =
itemHeader.type === 'attachment' &&
itemHeader.content_type !== 'application/json';
// TODO: Parse when needed for the tests
const isReplayVideo = (itemHeader.type as string) === 'replay_video';

try {
Expand Down
Loading