Repository navigation
Conversation
mhatipog
marked this pull request as ready for review
October 15, 2026 19:00
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
EventScrubber.scrub_request()filtersrequest.headers,request.cookies, andrequest.data, but omitsrequest.query_string. The AWS Lambda integration populates that field as a mapping fromqueryStringParameterswhen the explicitdata_collectionconfiguration is not used. As a result, sensitive values undertoken/authorization/passwordremain in a captured event even though the same keys are covered elsewhere by the existing denylist.This is a specific sensitive-data redaction gap, not a claim of a separately demonstrated remote exploit.
Fix
Reuse the existing
scrub_dictandscrub_listonrequest.query_string:data_collection.Reproduction and tests
EventScrubber().scrub_event({"request": {"query_string": {"token": "SECRET"}}})retainsSECRET.[Filtered]and the standard!configredaction metadata.sentry_sdk.capture_event()path locally and verified both the filtered value and_meta.action_requiredfor the forked PR workflows, which need maintainer approval to run.Related to #4441's expectations for query parameter scrubbing, but does not close #4441 because that report concerns raw string query parameters; this fix addresses mappings (including AWS Lambda).