Skip to content

feat(boto3): Use object.* ops for S3 Object operations - #8037

Open
pabloDeputter wants to merge 1 commit into
major/3.0from
pablo/boto3-s3-object-ops
Open

pabloDeputter wants to merge 1 commit into
major/3.0from
pablo/boto3-s3-object-ops

Conversation

@pabloDeputter

Copy link
Copy Markdown
Member

Description

S3 object operations now override default rpc op with object.*. Other S3 operations, e.g. ListBuckets, stay on rpc.

(

)

(todo: update migration guide, like in the PR before)

@pabloDeputter
pabloDeputter marked this pull request as ready for review October 14, 2026 18:22
@pabloDeputter
pabloDeputter requested a review from a team as a code owner October 14, 2026 18:22
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Results 📊

✅ 56154 passed | ❌ 1 failed | ⏭️ 2872 skipped | Total: 59027 | Pass Rate: 95.13% | Execution Time: 156m 48s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -81915
Passed Tests 📉 -77512
Failed Tests 📈 +1
Skipped Tests 📉 -4404

➕ New Tests (1)

View new tests
  • test_request_data
    • File: tests.integrations.sanic.test_sanic
    • Status: ❌ Failing

❌ Failed Tests

test_request_data

File: tests.integrations.sanic.test_sanic
Suite: py3.10-sanic-v25.12.1
Error: OSError: [Errno 98] error while attempting to bind on address ('127.0.0.1', 56521): address already in use

Stack Trace
tests/integrations/sanic/test_sanic.py:111: in test_request_data
    with c as client:
/usr/lib/python3.10/contextlib.py:135: in __enter__
    return next(self.gen)
tests/integrations/sanic/test_sanic.py:95: in reusable_client
    client.__enter__()
.tox/py3.10-sanic-v25.12.1/lib/python3.10/site-packages/sanic_testing/reusable.py:65: in __enter__
    self.run()
.tox/py3.10-sanic-v25.12.1/lib/python3.10/site-packages/sanic_testing/reusable.py:77: in run
    self._server = self._run(self._server_co)
.tox/py3.10-sanic-v25.12.1/lib/python3.10/site-packages/sanic_testing/reusable.py:198: in _run
    return self._loop.run_until_complete(coro)
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
.tox/py3.10-sanic-v25.12.1/lib/python3.10/site-packages/sanic/mixins/startup.py:602: in create_server
    return await serve(
.tox/py3.10-sanic-v25.12.1/lib/python3.10/site-packages/sanic/server/async_server.py:111: in __await__
    self.server = task.result()
/usr/lib/python3.10/asyncio/base_events.py:1519: in create_server
    raise OSError(err.errno, 'error while attempting '
E   OSError: [Errno 98] error while attempting to bind on address ('127.0.0.1', 56521): address already in use

✅ Patch coverage is 100.00% (14 of 14 changed executable lines covered; target 80%).
Project statement coverage is 90.06% (down 0.20 percentage points from base (009f15f) to head (64bf8c6)).

Changed files with executable lines (2)
File Patch coverage Changed executable lines
sentry_sdk/consts.py 100.00% 10/10 covered
sentry_sdk/integrations/boto3/_services/s3.py 100.00% 4/4 covered
Coverage diff
@@            Coverage Diff             @@
##        master     #8037       +/-##
==========================================
- Coverage    90.26%    90.06%    -0.20%
==========================================
  Files          202       197        -5
  Tracked lines     26660     20986     -5674
  Branches      9926      7206     -2720
==========================================
- Hits         24062     18900     -5162
+ Misses        2598      2086      -512
+ Partials      1510      1233      -277

Generated by Coverage Action

@pabloDeputter
pabloDeputter added this pull request to stack #8038 October 14, 2026 20:14
@pabloDeputter
pabloDeputter removed this pull request from stack #8038 October 14, 2026 20:15

@sentrivana sentrivana left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the associated conventions PRs are approved this looks good to me.

@pabloDeputter
pabloDeputter force-pushed the pablo/boto3-default-rpc-op branch from 72498a1 to c153076 Compare October 15, 2026 13:38
Base automatically changed from pablo/boto3-default-rpc-op to major/3.0 October 15, 2026 13:42
@pabloDeputter
pabloDeputter force-pushed the pablo/boto3-s3-object-ops branch from e9f873f to 64bf8c6 Compare October 16, 2026 15:27

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants