Skip to content

ref(boto3): Use rpc as the default span op - #8035

Merged
pabloDeputter merged 4 commits into
major/3.0from
pablo/boto3-default-rpc-op
Oct 15, 2026
Merged

pabloDeputter merged 4 commits into
major/3.0from
pablo/boto3-default-rpc-op

Conversation

@pabloDeputter

Copy link
Copy Markdown
Member

Description

boto3 spans now use sentry.op = rpc instead of http.client. Service extensions can (and will in the future) provide a more specific op with get_span_op(), e.g. db for DynamoDB.

(todo: add to migration guide?)

Why

  • boto3 span represents an AWS api call, not an HTTP request; the HTTP request is already captured as the as the http.client child
  • JS already also defaults AWS SDK spans to rpc

It also lets these spans use new name and description rules in sentry-conventions, e.g. (getsentry/sentry-conventions#714, #717), e.g. Lambda.Invoke billing instead of POST https://lambda.…

@pabloDeputter
pabloDeputter marked this pull request as ready for review October 14, 2026 16:50
@pabloDeputter
pabloDeputter requested a review from a team as a code owner October 14, 2026 16:50
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Results 📊

✅ 56199 passed | ⏭️ 2872 skipped | Total: 59071 | Pass Rate: 95.14% | Execution Time: 158m 49s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -81871
Passed Tests 📉 -77467
Failed Tests —
Skipped Tests 📉 -4404

All tests are passing successfully.

✅ Patch coverage is 100.00% (2 of 2 changed executable lines covered; target 80%).
Project statement coverage is 90.04% (down 0.19 percentage points from base (31e09fb) to head (4a4bf08)).

Changed files with executable lines (2)
File Patch coverage Changed executable lines
sentry_sdk/consts.py 100.00% 1/1 covered
sentry_sdk/integrations/boto3/_instrumentation.py 100.00% 1/1 covered
Coverage diff
@@            Coverage Diff             @@
##        master     #8035       +/-##
==========================================
- Coverage    90.23%    90.04%    -0.19%
==========================================
  Files          202       193        -9
  Tracked lines     26660     20939     -5721
  Branches      9926      7208     -2718
==========================================
- Hits         24055     18854     -5201
+ Misses        2605      2085      -520
+ Partials      1510      1233      -277

Generated by Coverage Action

@pabloDeputter
pabloDeputter added this pull request to stack #8038 October 14, 2026 20:14
@pabloDeputter
pabloDeputter removed this pull request from stack #8038 October 14, 2026 20:15

@sentrivana sentrivana left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration guide too, please

@pabloDeputter
pabloDeputter force-pushed the pablo/boto3-default-rpc-op branch from 72498a1 to c153076 Compare October 15, 2026 13:38
@pabloDeputter
pabloDeputter merged commit 6c430fb into major/3.0 Oct 15, 2026
149 checks passed
@pabloDeputter
pabloDeputter deleted the pablo/boto3-default-rpc-op branch October 15, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants