Skip to content

fix(breakpad): avoid double decref after on_crash #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshuaMoelans merged 1 commit into from
Aug 14, 2026
Merged

fix(breakpad): avoid double decref after on_crash #1990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/backends/sentry_backend_breakpad.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,9 +160,8 @@ breakpad_backend_callback(const google_breakpad::MinidumpDescriptor &descriptor,
#endif

SENTRY_SIGNAL_SAFE_LOG("DEBUG invoking `on_crash` hook");
sentry_value_t result
= options->on_crash_func(uctx, event, options->on_crash_data);
should_handle = !sentry_value_is_null(result);
event = options->on_crash_func(uctx, event, options->on_crash_data);
should_handle = !sentry_value_is_null(event);
Comment on lines +163 to +164

@JoshuaMoelans JoshuaMoelans Aug 13, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still call decref(event) later on, but since this would now happen on a sentry_value_new_null it's a no-op (consistent with how inproc handles this). We could also remove the decrefs from both 🤔

}

sentry__transport_suspend(options->transport);
Expand Down
Loading