Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 task
Contributor
size-limit report 📦Compared: a641698 (PR test merge using develop at 1177c46) Against: 1177c46 (develop) · base run #63809 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 4 not successful, 56 successful. See the run.
Successful checks
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Since v11,
streamObjectcreates nogen_aispans on AI SDK v4–v6, because the orchestrion config injectsgenerateText,streamTextandgenerateObjectbut notstreamObject. On v4 and v5 it isn't deprecated, and v10 traced it on v4–v6. It returns synchronously likestreamText, so it reuses that deferred-end path, and also awaitsobjectso a schema failure fails the span, asgenerateObjectdoes.How to review: Start with the config entry in
orchestrion/config/vercel-ai.ts; the subscriber changes widen the existingstreamTextchecks. The new v4 and v6 tests fail ondevelop. v7 stays skipped, as forgenerateObject: the object functions are deprecated, andaiv7 doesn't publish them onai:telemetryand won't (vercel/ai#24125).Unsure about:
aileaves the result promises pending, theinvoke_agentspan never ends and isn't sent. That happens on a failed model call on v4, the same asstreamText, and when the caller stops reading early on v6, wherestreamTextresolves.generateObject. It declaresfunction streamObject(in bothdist/index.jsanddist/index.mjs.streamTextissues that now also apply tostreamObject. Happy to fix each in a follow-up:callIdmaps;doStreamloses its operation ID;errorchunk leaves the model-call spanok.Closes #25779