Skip to content

fix(v10/opentelemetry): Support @opentelemetry/api 1.10 types - #25650

Open
andreiborza wants to merge 2 commits into
v10from
ab/v10-otel-api-1.10-types
Open

andreiborza wants to merge 2 commits into
v10from
ab/v10-otel-api-1.10-types

Conversation

@andreiborza

Copy link
Copy Markdown
Member

What

The v10 SDK now builds against @opentelemetry/api 1.10.0 and accepts its attribute types. The published dependency ranges stay at ^1.9.1.

  • Custom samplers can pass 1.10 attributes to wrapSamplingDecision.
  • SentryTracerProvider accepts OTel resource attributes.
  • The monorepo installs one @opentelemetry/api copy (1.10.0).

Why

1.10.0 changes OTel attribute values to unknown, which broke custom samplers and the v10 CI. A ^1.10.0 range would force a second API copy on users with 1.9.x, and that copy silently disables tracing.

Replaces #25633.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 48acf4a. Configure here.

Comment thread packages/opentelemetry/src/sampler.ts
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 28.21 kB added added
@sentry/browser - with treeshaking flags 26.66 kB added added
@sentry/browser (incl. Tracing) 47.23 kB added added
@sentry/browser (incl. Tracing + Span Streaming) 49.03 kB added added
@sentry/browser (incl. Tracing, Profiling) 52.02 kB added added
@sentry/browser (incl. Tracing, Replay) 86.64 kB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 76.27 kB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 91.35 kB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 103.97 kB added added
@sentry/browser (incl. Feedback) 45.38 kB added added
@sentry/browser (incl. sendFeedback) 33.01 kB added added
@sentry/browser (incl. FeedbackAsync) 38.14 kB added added
@sentry/browser (incl. Metrics) 29.31 kB added added
@sentry/browser (incl. Logs) 29.55 kB added added
@sentry/browser (incl. Metrics & Logs) 30.22 kB added added
@sentry/react 30.02 kB added added
@sentry/react (incl. Tracing) 49.53 kB added added
@sentry/vue 34.1 kB added added
@sentry/vue (incl. Tracing) 49.61 kB added added
@sentry/svelte 28.24 kB added added
CDN Bundle 30.62 kB added added
CDN Bundle (incl. Tracing) 49.18 kB added added
CDN Bundle (incl. Logs, Metrics) 32.19 kB added added
CDN Bundle (incl. Tracing, Logs, Metrics) 50.49 kB added added
CDN Bundle (incl. Replay, Logs, Metrics) 71.62 kB added added
CDN Bundle (incl. Tracing, Replay) 86.87 kB added added
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.16 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 92.68 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 93.97 kB added added
CDN Bundle - uncompressed 91 kB added added
CDN Bundle (incl. Tracing) - uncompressed 148.26 kB added added
CDN Bundle (incl. Logs, Metrics) - uncompressed 95.71 kB added added
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 152.24 kB added added
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 221.06 kB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 268.08 kB added added
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 272.05 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 281.78 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 285.74 kB added added
@sentry/nextjs (client) 52.18 kB added added
@sentry/sveltekit (client) 47.66 kB added added
@sentry/core/server 81.66 kB added added
@sentry/core/browser 67.73 kB added added
@sentry/node-core 64.12 kB added added
@sentry/node 127.37 kB added added
@sentry/node (incl. diagnostics channel injection) 171.57 kB added added
@sentry/node/import (ESM hook with diagnostics-channel injection) 166 B added added
@sentry/node/light 52.09 kB added added
@sentry/node - without tracing 76 kB added added
@sentry/aws-serverless 85.17 kB added added
@sentry/cloudflare (withSentry) - minified 185.74 kB added added
@sentry/cloudflare (withSentry) 458.03 kB added added

@andreiborza
andreiborza marked this pull request as ready for review October 22, 2026 12:16
@andreiborza
andreiborza requested a review from a team as a code owner October 22, 2026 12:16
@andreiborza
andreiborza requested review from Lms24, isaacs, mydea and nicohrubec and removed request for a team and mydea October 22, 2026 12:16

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants