Skip to content

chore: Pin pnpm 10 in Volta and remove .npmrc #25641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JPeer264 merged 2 commits into from
Oct 22, 2026
Merged

chore: Pin pnpm 10 in Volta and remove .npmrc #25641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08380f8
chore: Pin pnpm 10 in Volta and remove .npmrc
JPeer264 Oct 21, 2026
a75ce3e
Merge branch 'develop' into jp/volta-pnpm-10-pin
JPeer264 Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .agents/skills/fix-security-vulnerability/scripts/classify-alerts.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function fetchOpenAlerts() {
}

// Resolve a dependency's installed directory, preferring the consumer's nested node_modules and
// falling back to the hoisted root node_modules (`node-linker=hoisted` in .npmrc hoists most deps to the root).
// falling back to the hoisted root node_modules (`nodeLinker: hoisted` in pnpm-workspace.yaml hoists most deps to the root).
function resolveDepDir(name, baseDir) {
const candidates = [join(baseDir, 'node_modules', name), join(REPO_ROOT, 'node_modules', name)];
return candidates.find(dir => existsSync(join(dir, 'package.json')));
Expand Down
3 changes: 0 additions & 3 deletions .npmrc
View file
Open in desktop

This file was deleted.

5 changes: 3 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,9 @@ Developer Documentation.

## Setting up an Environment

We use [Volta](https://volta.sh/) to ensure we use consistent versions of node and pnpm. Make sure to enable
[pnpm support in Volta](https://docs.volta.sh/advanced/pnpm).
We use [Volta](https://volta.sh/) to ensure we use consistent versions of node and pnpm. Volta manages pnpm only when
[pnpm support](https://docs.volta.sh/advanced/pnpm) is enabled, so add `export VOLTA_FEATURE_PNPM=1` to your shell
profile (for example `~/.zshrc`).

`sentry-javascript` is a monorepo containing several packages, managed with pnpm workspaces and Nx. To get started,
install all dependencies, and then perform an initial build, so TypeScript can read all of the linked type definitions.
Expand Down
6 changes: 5 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,13 @@
"yalc:publish": "nx run-many -t yalc:publish"
},
"packageManager": "pnpm@12.11.2",
"//_volta_comment": [
"Volta cannot start pnpm 11 or newer (volta-cli/volta#2114). It starts this pnpm 10 version, which switches to the `packageManager` version.",
"Volta reads the pnpm version only when `VOLTA_FEATURE_PNPM=1` is set, see CONTRIBUTING.md."
],
"volta": {
"node": "24.22.1",
"pnpm": "9.15.9"
"pnpm": "10.34.6"
},
"//_workspaces_comment": [
"pnpm reads the workspace packages from pnpm-workspace.yaml. Deno and the repo scripts read this list.",
Expand Down
Loading