Repository navigation
Conversation
Adds `assertSourceMapUpload` to test-utils and uses it in the Astro, SvelteKit, Remix and Nuxt source map apps. The SolidStart 1, SolidStart 2 and TanStack Start apps now build against the mock Sentry server and run the same assertions, so the source map handling of every framework SDK that strips maps itself is covered before the bundler plugins take it over.
Contributor
size-limit report 📦Compared: 1097581 (PR test merge using develop at ef5596b) Against: ef5596b (develop) · base run #63094 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 4 failing, 54 successful. See the run.
Successful checks
|
timfish
marked this pull request as ready for review
October 22, 2026 10:00
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The framework SDKs that strip source maps themselves (Astro, SvelteKit, Remix, Nuxt, SolidStart, TanStack Start) are about to hand that job to the bundler plugins. Before that, the E2E apps need to pin down what the SDKs do today: maps reach Sentry with the debug IDs the shipped bundles carry, the bundles reference no map, and no map stays where it would be served.
The Astro, SvelteKit, Remix and Nuxt source map apps already asserted most of this, each with its own copy of the checks. They now call a shared
assertSourceMapUploadhelper in test-utils, which also checks that nosourceMappingURLcomment points at a deleted map. The SolidStart 1, SolidStart 2 and TanStack Start apps had no build assertions, so they now build against the mock Sentry server and run the same helper before their Playwright suites. No new apps or CI jobs.