Repository navigation
Conversation
Member
Author
|
bugbot run |
3 tasks done
Contributor
size-limit report 📦Compared: c2007eb (PR test merge using develop at e1026aa) Against: e1026aa (develop) · base run #63365 ✅ Baseline matches: this diff contains only this PR's changes.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e4c2c57. Configure here.
|
|
||
| if (flushNow) { | ||
| flushPendingClientAggregates(); | ||
| } |
There was a problem hiding this comment.
Flush-now skips existing aggregates
Medium Severity
When a request session settles after client.flush(), flushNow only sends if this call created the aggregate. Another request that records during that wait can already have opened a bucket, so this session is added and not sent. The in-flight flush then drains the transport without it, and a shutdown flush can drop the session.
Reviewed by Cursor Bugbot for commit e4c2c57. Configure here.
Member
There was a problem hiding this comment.
I think one way we could solve this is by adding something like an afterFlushProcessing client hook that the client emits in its flush method after determining clientFinished. This should allow us to get rid of the flushNow flag that only worked locally for this request
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 not successful, 64 successful. See the run.
Successful checks
|
Lms24
reviewed
Oct 22, 2026
Lms24
left a comment
Lms24
left a comment
Member
There was a problem hiding this comment.
Thanks for fixing this, I admittedly forgot about the server side part when we made the change in browser.
Took me a bit to understand the pendingRequests logic but I think it's fine and shouldn't hurt us or leak memory (that is assuming the isolationScope cleans up at which point the references to the pending errors should be gc'd).
I think we still should address the bugbot comment but otherwise, looks great!
The scenario sets `sessionFlushingDelayMS` on `httpIntegration`, which has no effect with `@sentry/bun`, so the session aggregate arrives after the test timeout.
…n-filtered-errors
A session that settled while `client.flush()` waited for event processing was only sent when it opened a new aggregate. If another request opened an aggregate during that wait, the session joined it and that flush did not send it. Add an `afterFlushProcessing` client hook, which `flush()` emits after event processing and before the transport flush. Request session aggregates now also send on this hook.
…n-filtered-errors
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors that
ignoreErrors,beforeSendor an event processor drops no longer mark the request session as errored or crashed. Errors thatsampleRatedrops still count. This is the same rule that already applies to client sessions since #22671.Before,
ServerRuntimeClientset the request session status incaptureException/captureEvent, before the event pipeline ran. Now the status is set at the same point in the pipeline as the client session update.Event processing can finish after the response ends (e.g. async ContextLines reads). Because of this, the request session now waits for its pending error events before it is recorded. If
client.flush()runs during that wait, the session is sent immediately. This is necessary because the flush sends the aggregate before it waits for event processing.Fixes #25605