Skip to content

ci(size-limit): Don't enforce size limits on release PRs #25631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JPeer264 merged 1 commit into from
Oct 21, 2026
Merged

ci(size-limit): Don't enforce size limits on release PRs #25631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions dev-packages/size-limit-gh-action/index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import { getArtifactsForBranchAndWorkflow } from './utils/getArtifactsForBranchA
import { MAX_INCREASE_BYTES, SizeLimitFormatter } from './utils/SizeLimitFormatter.mjs';

const OVERRIDE_LABEL = 'Accept Bundlesize Increase';
const RELEASE_BRANCH_PREFIX = 'prepare-release/';
const SIZE_LIMIT_HEADING = '## size-limit report 📦 ';
const ARTIFACT_NAME = 'size-limit-action';
const ACTION_DIRECTORY = path.dirname(fileURLToPath(import.meta.url));
Expand Down Expand Up @@ -148,7 +149,10 @@ async function run() {
}

let failure;
if (!base) {
if (pr.head.ref.startsWith(RELEASE_BRANCH_PREFIX)) {
// Release PRs target master, which has no baseline and would include every change since the last release anyway
core.info('Release PR detected. Reporting bundle sizes without enforcing limits.');
} else if (!base) {
failure = 'No baseline size measurements found. Re-run after the base build completes.';
bodyParts.push(failure);
} else if (increases.length > 0) {
Expand Down Expand Up @@ -186,7 +190,7 @@ async function run() {
});
}

if (increases.length > 0 && !comments.some(comment => comment.body === failure)) {
if (failure && increases.length > 0 && !comments.some(comment => comment.body === failure)) {
await octokit.rest.issues.createComment({
...repo,
issue_number: pr.number,
Expand Down
Loading