Skip to content

fix(v10/core): Use trace_metric data category for metrics rate limits and client reports - #25612

Open
Lms24 wants to merge 1 commit into
v10from
backport/v10-trace-metric-data-category
Open

Lms24 wants to merge 1 commit into
v10from
backport/v10-trace-metric-data-category

Conversation

@Lms24

@Lms24 Lms24 commented Oct 21, 2026

Copy link
Copy Markdown
Member

Backport of: #25606

Differences to the original PR

  • packages/core/src/metrics/internal.ts and packages/core/test/lib/metrics/internal.test.ts: no change. On v10, _INTERNAL_captureMetric does not record client reports when beforeSendMetric drops a metric (and has no callback_error handling), so there is no metric category to rename there.
  • packages/core/test/lib/transports/base.test.ts: the new trace_metric rate limit test expects recordDroppedEvent('ratelimit_backoff', 'trace_metric') without a count, because the v10 transport does not pass item_count to recordDroppedEvent. Also added the Envelope type import, which the v10 test file did not have. The 413 container item test from the original PR does not exist on v10, so it was not touched.

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 28.21 kB added added
@sentry/browser - with treeshaking flags 26.66 kB added added
@sentry/browser (incl. Tracing) 47.23 kB added added
@sentry/browser (incl. Tracing + Span Streaming) 49.04 kB added added
@sentry/browser (incl. Tracing, Profiling) 52.02 kB added added
@sentry/browser (incl. Tracing, Replay) 86.64 kB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 76.27 kB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 91.35 kB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 103.97 kB added added
@sentry/browser (incl. Feedback) 45.38 kB added added
@sentry/browser (incl. sendFeedback) 33.02 kB added added
@sentry/browser (incl. FeedbackAsync) 38.14 kB added added
@sentry/browser (incl. Metrics) 29.31 kB added added
@sentry/browser (incl. Logs) 29.55 kB added added
@sentry/browser (incl. Metrics & Logs) 30.22 kB added added
@sentry/react 30.02 kB added added
@sentry/react (incl. Tracing) 49.53 kB added added
@sentry/vue 34.1 kB added added
@sentry/vue (incl. Tracing) 49.61 kB added added
@sentry/svelte 28.24 kB added added
CDN Bundle 30.63 kB added added
CDN Bundle (incl. Tracing) 49.18 kB added added
CDN Bundle (incl. Logs, Metrics) 32.19 kB added added
CDN Bundle (incl. Tracing, Logs, Metrics) 50.49 kB added added
CDN Bundle (incl. Replay, Logs, Metrics) 71.62 kB added added
CDN Bundle (incl. Tracing, Replay) 86.88 kB added added
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.16 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 92.68 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 93.97 kB added added
CDN Bundle - uncompressed 91 kB added added
CDN Bundle (incl. Tracing) - uncompressed 148.26 kB added added
CDN Bundle (incl. Logs, Metrics) - uncompressed 95.71 kB added added
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 152.24 kB added added
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 221.06 kB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 268.08 kB added added
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 272.05 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 281.78 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 285.74 kB added added
@sentry/nextjs (client) 52.18 kB added added
@sentry/sveltekit (client) 47.66 kB added added
@sentry/core/server 81.66 kB added added
@sentry/core/browser 67.73 kB added added
@sentry/node-core 64.04 kB added added
@sentry/node 127.22 kB added added
@sentry/node (incl. diagnostics channel injection) 171.41 kB added added
@sentry/node/import (ESM hook with diagnostics-channel injection) 166 B added added
@sentry/node/light 52.09 kB added added
@sentry/node - without tracing 75.82 kB added added
@sentry/aws-serverless 84.99 kB added added
@sentry/cloudflare (withSentry) - minified 204.93 kB added added
@sentry/cloudflare (withSentry) 505.2 kB added added

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants