Repository navigation
Conversation
s1gr1d
requested review from
chargome,
isaacs,
mydea and
nicohrubec
and removed request for
a team
October 20, 2026 10:39
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> # Conflicts: # packages/hono/package.json
Contributor
size-limit report 📦Compared: 09b824b (PR test merge using develop at 6fb6b07) Against: 6fb6b07 (develop) · base run #62924 ✅ Baseline matches: this diff contains only this PR's changes.
|
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7fbb96f. Configure here.
| 'network.transport': transport, | ||
| 'network.type': addressType?.toLowerCase(), | ||
| 'client.address': ipAddress, | ||
| 'network.peer.address': ipAddress, |
There was a problem hiding this comment.
Hardcoded span attribute names
Low Severity
The rewritten connection-info path and its tests use string literals such as client.address, client.port, network.peer.address, network.peer.port, and network.transport. @sentry/conventions already exports these, and I flagged this because the PR review rules require those constants in SDK source and in span-attribute assertions.
Additional Locations (2)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 7fbb96f. Configure here.
Member
There was a problem hiding this comment.
^^ although this was pre-existing, maybe we can fix this while already here!
JPeer264
self-requested a review
October 20, 2026 12:29
s1gr1d
added a commit
that referenced
this pull request
Oct 20, 2026
Same fix as #25557, applied to nuxt-5. It failed the same way on #25552 (`container e2e-tests-nuxt-5-mongo is unhealthy`) The floating `mongo:8` tag moved to 8.3 on 2026-10-17. On CI the container goes unhealthy some seconds after start. That is much earlier than the healthcheck retries allow, so the server process exits, and Docker then reports the container as unhealthy. If setup fails again, the container logs now print, so we can see why mongod exits.
nicohrubec
approved these changes
Oct 21, 2026
nicohrubec
left a comment
nicohrubec
left a comment
Member
There was a problem hiding this comment.
the bugbot comments look worth taking a look but else this looks neat
s1gr1d
enabled auto-merge (squash)
October 21, 2026 13:56
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 failing, 63 successful. See the run.
Successful checks
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares for Hono 5 support. Hono 5 moves its
getConnInfohelpers out ofhono, so the SDK now reads the client address and port from the runtime objects that Hono already has. It no longer imports or loads any Hono helper module.Results:
client.address, are kept@hono/node-serveris no longer an optional peer dependency (we only needed it for the conn info)Also fixes #25540 and adds a "bundled-app" integration test for this case.
Part of #25223