Repository navigation
ci: Run optional E2E tests in a separate workflow - #25548
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 failing, 63 successful. See the run.
Successful checks
|
mydea
reviewed
Oct 20, 2026
| run: ${{ matrix.build-command || 'pnpm test:build' }} | ||
|
|
||
| - wait: [install-playwright] | ||
| - name: Trigger optional E2E tests |
Member
There was a problem hiding this comment.
no strong feeling, but maybe this could be a JS-based in-repo action (like size limit etc)? would maybe be a bit easier to read/adjust in the future?
Member
Author
There was a problem hiding this comment.
Good idea, moved the dispatch, wait and report logic into an in-repo optional-e2e-gh-action.
…rkflow # Conflicts: # .github/workflows/build.yml
Contributor
size-limit report 📦Compared: 76b0c7c (PR test merge using develop at 5e2b904) Against: 5e2b904 (develop) · base run #62910 ✅ Baseline matches: this diff contains only this PR's changes.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1983247. Configure here.
andreiborza
marked this pull request as ready for review
October 21, 2026 12:07
mydea
reviewed
Oct 21, 2026
|
|
||
| # This job only waits for optional-e2e.yml, which can take most of an hour. GitHub runners are free for public | ||
| # repos and Namespace runners are paid per minute, so the wait runs here and the tests run on Namespace. | ||
| runs-on: ubuntu-24.04 |
mydea
added this pull request to stack #25617
October 21, 2026 12:39
andreiborza
pushed a commit
that referenced
this pull request
Oct 21, 2026
…25616) Stacked on #25548. The optional E2E workflow copied most of \`job_e2e_tests\` from build.yml, so the two could drift apart. The steps that prepare a test application (runtimes, artifact downloads including the AWS ones, prepare/validate, copy to temp, pnpm overrides) now live in \`.github/actions/prepare-e2e-test\`. The action downloads from the current run by default; optional-e2e.yml passes the build.yml run ID and a token instead. Installing Playwright, building and running the test stay in the workflows: Playwright installs as a background step, and [a composite action cannot declare background steps](https://docs.github.com/actions/using-workflows/workflow-syntax-for-github-actions). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Optional E2E tests now run in their own workflow. The build workflow starts it, waits for it to finish, and reports failures in one PR comment.
Why
Failed optional tests made the PR show a red cross, even though the PR could be merged.