Repository navigation
Conversation
The Next.js server dropped spans for Sentry ingest requests by setting the `beforeSampling` decision to false. Core has ignored that decision since `SentrySampler` was removed, so these spans were sent again. Match them with `ignoreSpans` attribute patterns instead, which core checks when a span starts. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Lms24
changed the title
ignoreSpans
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #25441.
This PR fixes an issue where the SDK previously sent
http.clientspans for requests to sentry. Apparently such spans can happen in NextJS edge runtime, despite us trying to avoid this by using the native fetch implentation to send our telemetry. These spans accidentally slipped through because we removedSentrySamplerwhich was needed for the previousbeforeSamplingapproach due to the NextJS spans <> Sentry SDK interop.This PR adds a new, span-streaming-native approach by using a pre-defined
ignoreSpansfilter criterion, matching the URL query against the url query attributes.