Repository navigation
test(node): skip the Prisma 8 suite on Node 20 - #25421
Merged
Merged
Conversation
Prisma 8 requires Node 22.12: its `@prisma/cli-engine` peer declares `engines.node >=22.12.0`. On Node 20, the suite's install of `@prisma/orm-postgres` now fails outright. npm 10, which Node 20 ships, crashes with `Cannot read properties of null (reading 'edgesOut')` on a peer conflict deep in Prisma's tree, which `vitest@4.1.12` introduced: its optional `@vitest/browser-webdriverio` peer is `^4.1.11`, and that package has no 4.1.12, so it resolves to 4.1.11, which peers on `vitest@4.1.11`. The suite now runs on Node 22 and later only. That also removes its Node 20 test of `require(esm)` loading the ORM uninstrumented, which covered a setup Prisma does not support. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
isaacs
requested review from
JPeer264 and
mydea
and removed request for
a team
October 15, 2026 16:23
logaretm
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prisma 8 requires Node 22.12: its
@prisma/cli-enginepeer declaresengines.node >=22.12.0. On Node 20, the suite's install of@prisma/orm-postgresnow fails outright. npm 10, which Node 20 ships, crashes withCannot read properties of null (reading 'edgesOut')on a peer conflict deep in Prisma's tree, whichvitest@4.1.12introduced: its optional@vitest/browser-webdriveriopeer is^4.1.11, and that package has no 4.1.12, so it resolves to 4.1.11, which peers onvitest@4.1.11.The suite now runs on Node 22 and later only. That also removes its Node 20 test of
require(esm)loading the ORM uninstrumented, which covered a setup Prisma does not support.