Repository navigation
test(e2e): Fix peer dependency issues in hydrogen-react-router-7 - #25400
Merged
Merged
Conversation
`react-router` was on 7.18.2 while `@react-router/dev`, `@react-router/fs-routes` and `react-router-dom` stayed on 7.13.0. The app therefore resolved `@react-router/node` 7.13.0, below the `>=7.15.0` that `@sentry/react-router` requires as a peer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`@shopify/hydrogen@2025.5.0` and the deprecated `@shopify/remix-oxygen` pinned React Router versions that don't match the app's. Hydrogen 2026.4.7 and its `@shopify/hydrogen/oxygen` entry point replace both, with every React Router package on 7.16.0, the version they require. The unused Tailwind and ESLint dependencies had outdated peers and are dropped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
changed the title
mydea
marked this pull request as ready for review
October 15, 2026 12:50
s1gr1d
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes every peer dependency issue in
hydrogen-react-router-7. The app now installs cleanly withstrict-peer-dependencies.react-routerwas on 7.18.2, while@react-router/dev,@react-router/fs-routesandreact-router-domwere still on 7.13.0. The app therefore resolved@react-router/node7.13.0, below the>=7.15.0that@sentry/react-routerrequires as a peer since feat(react-router)!: Raise minimum supported React Router version to >= 7.15 #22481, so it was testing a version the SDK doesn't support. All React Router packages are now on 7.16.0.@shopify/hydrogen@2025.5.0pinnedreact-router@7.6.0, and@shopify/remix-oxygenpinned~7.16.0. Hydrogen 2026.4.7 (the latest 2026.4 release) requires~7.16.0, which is why all React Router packages are on 7.16.0. The newer 2026.10 line changes its peers completely, so I didn't move to it.reactandreact-dommove to^18.3.1, as Hydrogen requires.@shopify/remix-oxygen: it's deprecated, so the app now importscreateRequestHandlerandgetStorefrontHeadersfrom@shopify/hydrogen/oxygen, and the React Router types and session helpers fromreact-router. It was also the cause of a type error with the newer Hydrogen.@tailwindcss/vite(an alpha requiring Vite 5) and the ESLint packages weren't used at all and had outdated peers, so they're removed along with the unusedlintscript.🤖 Generated with Claude Code