Repository navigation
ci(e2e): Run all E2E tests when CI config changes - #25391
Merged
Merged
Conversation
The E2E matrix only includes apps affected according to Nx, which doesn't know about `.github/**`. A PR that only changes workflows or actions therefore ran no E2E tests. Like the other test jobs, the matrix now includes everything when `changed_ci` is set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
added this pull request to stack #25392
October 15, 2026 11:37
mydea
marked this pull request as ready for review
October 15, 2026 11:52
JPeer264
approved these changes
Oct 15, 2026
JPeer264
left a comment
JPeer264
left a comment
Member
There was a problem hiding this comment.
The mentioned tradeoffs are OK given that we would break something by accident
mydea
removed this pull request from stack #25392
October 15, 2026 11:58
mydea
added this pull request to stack #25397
October 15, 2026 11:58
mydea
removed this pull request from stack #25397
October 15, 2026 12:51
mydea
added this pull request to stack #25401
October 15, 2026 12:52
mydea
removed this pull request from stack #25401
October 15, 2026 12:55
mydea
added this pull request to stack #25405
October 15, 2026 12:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The E2E matrix only includes apps whose
@sentry/*dependencies Nx marks as affected, or that changed themselves. Nx doesn't track.github/**, so a PR that only changes workflows or actions (for example how E2E apps are installed or run) gets an empty E2E matrix and never exercises its own change.The other test jobs already handle this through
changed_ci(any change under.github/). The required and optional matrix steps now drop--basein that case.getTestMatrix.mjsalready returns every app without--base, as on pushes todevelop. Optional apps keep their existing conditions: they still don't run on fork PRs, Dependabot PRs or release branches.The tradeoff is that unrelated
.githubchanges, such asCODEOWNERS, also run the full matrix. That matches how the rest of CI treats them.🤖 Generated with Claude Code