Repository navigation
fix(server-utils): Nest LangChain run spans under their parent run - #25364
Draft
RulaKhaled wants to merge 1 commit into
Draft
RulaKhaled wants to merge 1 commit into
RulaKhaled wants to merge 1 commit into
Conversation
The callback handler ignored parentRunId, so nested runs became siblings under the caller's span. Chain and tool spans also lost the conversation id on @langchain/core >= 1.1.40, which keeps configurable out of run metadata. Start each run under its parent run's span, and share the conversation id across the open spans of the run tree. Fixes #25327 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
size-limit report 📦
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
Sentry.createLangChainCallbackHandler()passed explicitly, nested LangChain runs came out as siblings under the caller's span, and chain and tool spans had nogen_ai.conversation.idon@langchain/core>= 1.1.40.The handler ignored
parentRunId, so every run attached to whatever span was active. Each run now starts under its parent run's span, and falls back to the active span when the parent run has no span (e.g. a skipped LangGraph step). Since 1.1.40 only the chat span tends to learn the conversation id, so a run now inherits it from its parent, and a span that knows it passes it up to open ancestors without one. An id fromSentry.setConversationId()still wins.Limits. A run that ends before the id appears keeps none.
It also tightens the test from #25326 to assert the exact parent chain.
Fixes #25327
🤖 Generated with Claude Code