Repository navigation
fix(tanstackstart-react): Rewrite source paths of split route modules - #25361
Merged
Merged
Conversation
TanStack Start splits route files into virtual modules such as `index.tsx?tss-serverfn-split`. The uploaded source maps kept these queries and paths relative to the map's directory, so frames did not show the path of the source file. Remove the split queries and make source paths relative to the project root, so frames show paths such as `src/routes/index.tsx`. A user's `sourcemaps.rewriteSources` still takes precedence.
s1gr1d
marked this pull request as ready for review
October 14, 2026 12:01
s1gr1d
requested review from
chargome,
mydea and
nicohrubec
and removed request for
a team
October 14, 2026 12:01
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 27e85c7. Configure here.
nicohrubec
approved these changes
Oct 14, 2026
JPeer264
approved these changes
Oct 14, 2026
Co-authored-by: Jan Peer Stöcklmair <jan.peer@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TanStack Start splits route files into virtual modules such as
index.tsx?tss-serverfn-split. The uploaded source maps kept these queries, and their paths stayed relative to the map's directory, so frames did not show the source file.The default
rewriteSourceshook now removes the split queries and makes paths relative to the project root, such assrc/routes/index.tsx. A user'ssourcemaps.rewriteSourcesstill takes precedence.First PR of a stack for #21012.
Refs #21012