Skip to content

feat(browser): add LoaderSentry type - #25357

Open
faizansaiyed123 wants to merge 2 commits into
getsentry:developfrom
faizansaiyed123:feat/loader-sentry-type
Open

faizansaiyed123 wants to merge 2 commits into
getsentry:developfrom
faizansaiyed123:feat/loader-sentry-type

Conversation

@faizansaiyed123

Copy link
Copy Markdown

Summary

Adds an exported LoaderSentry type for TypeScript users of the CDN loader.

Changes

  • Adds and exports LoaderSentry.
  • Represents the APIs supported by the loader stub.
  • Uses void return types for queued methods to match the loader's runtime behavior.
  • Adds type tests covering supported and unsupported APIs.

This is a TypeScript-only solution and does not change the loader runtime behavior or expand the loader's queued method list.

Related to #21806.

@faizansaiyed123
faizansaiyed123 requested a review from a team as a code owner October 14, 2026 09:39
@faizansaiyed123
faizansaiyed123 requested review from logaretm and msonnb and removed request for a team October 14, 2026 09:39
@github-actions github-actions Bot added the external PR from an external contributor label Oct 14, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1c7706b. Configure here.

Comment thread packages/browser/test/loader.test-d.ts
@faizansaiyed123

Copy link
Copy Markdown
Author

Hi @Lms24, thanks for approving the TypeScript-only approach on #21806.

I've opened #25357, added the focused type tests, and addressed the BugBot feedback. The latest BugBot review found no issues, and the focused type tests pass locally.

The GitHub Actions workflows appear to be awaiting approval for this fork PR. Could you or another maintainer approve them so CI can run?

Thanks for your time!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external PR from an external contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant