Repository navigation
Conversation
isaacs
added this pull request to stack #25346
October 14, 2026 03:02
isaacs
force-pushed
the
isaacs/auto-instrument-default-export-re-exported
branch
from
October 14, 2026 04:03
2f1ee75 to
3dbce98
Compare
isaacs
marked this pull request as ready for review
October 14, 2026 04:03
isaacs
requested review from
JPeer264 and
mydea
and removed request for
a team
October 14, 2026 04:03
isaacs
force-pushed
the
isaacs/auto-instrument-default-export-re-exported
branch
from
October 14, 2026 16:17
3dbce98 to
07fff17
Compare
Contributor
size-limit report 📦
|
isaacs
force-pushed
the
isaacs/auto-instrument-default-export-re-exported
branch
from
October 14, 2026 16:41
07fff17 to
18be570
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 18be570. Configure here.
isaacs
force-pushed
the
isaacs/auto-instrument-default-export-re-exported
branch
2 times, most recently
from
October 14, 2026 18:38
475077b to
926eb7e
Compare
Base automatically changed from
isaacschlueter/js-3725-sentrycloudflarevite-auto-instrumentation-skips-the-worker
to
develop
October 14, 2026 23:36
isaacs
force-pushed
the
isaacs/auto-instrument-default-export-re-exported
branch
from
October 14, 2026 23:36
926eb7e to
89eecb0
Compare
The Vite plugin did not wrap a Worker entry whose default export comes
from another module:
```js
export { default } from './handler';
export { handler as default } from './handler';
```
The transform now imports the handler under a private name, wraps it
with `withSentry`, and exports the wrapper as the default.
The handler may already be wrapped in its own module, which the build
cannot see. So the wrap goes through `_INTERNAL_wrapUnlessInstrumented`,
the same guard that class re-exports use. For a handler object, a second
`withSentry` call adds nothing anyway, because each method is patched
only once.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
JPeer264
force-pushed
the
isaacs/auto-instrument-default-export-re-exported
branch
from
October 15, 2026 08:45
89eecb0 to
4d66f93
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Vite plugin did not wrap a Worker entry whose default export comes from another module:
The transform now imports the handler under a private name, wraps it with
withSentry, and exports the wrapper as the default.The handler may already be wrapped in its own module, which the build cannot see. So the wrap goes through
_INTERNAL_wrapUnlessInstrumented, the same guard that class re-exports use. For a handler object, a secondwithSentrycall adds nothing anyway, because each method is patched only once.