Repository navigation
test(sveltekit): Pin rollup to 4.64.5 - #25328
Merged
Merged
Conversation
JPeer264
changed the title
JPeer264
marked this pull request as ready for review
October 13, 2026 12:57
Lms24
approved these changes
Oct 13, 2026
chargome
approved these changes
Oct 13, 2026
Member
|
@JPeer264 please add a junior reminder to undo this once fixed (upstream?) |
Member
Author
|
Created an upstream issue sveltejs/kit#17425
|
51 tasks done
nicohrubec
added a commit
that referenced
this pull request
Oct 16, 2026
Backport of #25328. Pins Rollup to 4.64.5 so SvelteKit 2's Svelte 4 server build renders successfully instead of throwing `$state is not defined`. v10 has no `sveltekit-2-static` fixture, so the override applies only to `sveltekit-2`. The upstream ioredis note is omitted because this test has no database driver dependencies. Co-authored-by: Jan Peer Stöcklmair <jan.peer@sentry.io> Co-authored-by: GPT-6 <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinning for now to unblock the CI. Will follow up on an actual fix for this. I'm still not sure where the fix should go.