Repository navigation
fix(browser): Apply urlQueryParams to the Referer header - #25324
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
`document.referrer` holds the full URL of the previous page, including its query string. `getHttpRequestData` now applies `dataCollection.urlQueryParams` to it, so sensitive query params no longer reach `request.headers.Referer` of error events and static transactions, or the `http.request.header.referer` span attribute. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JPeer264
force-pushed
the
jp/browser-referer-sensitive-query-params
branch
from
October 13, 2026 14:15
70c9fc9 to
7958755
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 7958755. Configure here.
JPeer264
marked this pull request as ready for review
October 13, 2026 14:48
JPeer264
requested review from
logaretm and
msonnb
and removed request for
a team
October 13, 2026 14:48
Member
Author
|
ok TIL 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #25303
closes JS-3918
Description
This applies
dataCollection.urlQueryParamsto theRefererheader that the browser SDK collects fromdocument.referrer. Sensitive query params of the previous page are now filtered inrequest.headers.Refererof error events and static transactions, and in thehttp.request.header.refererspan attribute.Known issues
We do have a button to go to this page. By now adding filters we redirect to a potential broken page, but this can't and shouldn't be fixed, as this is filtered.
Sentry events
Before (11.7.0), the Referer has
jwt=sensitive-jwt-value: https://sentry-sdks.sentry.io/issues/7789837458/events/b27e43ad65b7405b8e030ebbcbff37e1/?project=4510555608449024After, the Referer has
jwt=[Filtered]: https://sentry-sdks.sentry.io/issues/7789837458/events/e5d05ddd3fd14c40a0c24e26e962223c/?project=4510555608449024