Repository navigation
Conversation
Lms24
added this pull request to stack #25311
October 13, 2026 08:29
Lms24
marked this pull request as ready for review
October 13, 2026 09:05
Lms24
requested review from
nicohrubec and
s1gr1d
and removed request for
a team
October 13, 2026 09:05
3 tasks done
s1gr1d
approved these changes
Oct 13, 2026
When the SDK enables hidden source maps, it deletes them after upload with `./dist/**/client/**/*.map` and `./dist/**/server/**/*.map`. Static output has neither folder and writes client assets to `<outDir>/_astro`, so the maps stayed in `dist` and got deployed. Also delete maps in the `build.assets` folder. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Astro removes the hidden `.prerender` folder at the end of the build, so these maps don't end up in the output today. Delete them ourselves anyway, so we don't rely on Astro internals for maps the SDK turned on. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Lms24
force-pushed
the
lms/fix-astro-static-sourcemaps-cleanup
branch
from
October 13, 2026 14:08
11c7708 to
7af7d56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the SDK turns on hidden source maps, it deletes them after upload with globs for
clientandserverfolders. Static output has neither folder and writes client assets to<outDir>/_astro, so the maps stayed indistand got deployed. This also deletes maps in thebuild.assetsfolder, and turns the leftover-maps check back on for the static variant of theastro-7-sourcemapse2e app. Found while working on #25304.