Repository navigation
test(node): Cover ioredis v6 in the diagnostics_channel suite - #25300
Merged
Merged
Conversation
ioredis 6.0.0 keeps the ioredis:command and ioredis:connect tracing channels and their payload shape, so redisIntegration already works with it. Add an ioredis-6 alias and run the existing expectations against both v5.11 and v6 so a future payload change is caught in CI. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
chargome
marked this pull request as ready for review
October 12, 2026 15:22
chargome
requested review from
JPeer264,
andreiborza,
isaacs,
mydea and
nicohrubec
and removed request for
a team,
isaacs and
mydea
October 12, 2026 15:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ioredis 6.0.0 keeps the same
ioredis:command/ioredis:connectchannels and payload as 5.11, soredisIntegrationalready works with it; this adds anioredis-6alias and runs the existingioredis-dcexpectations against both.