Repository navigation
fix(hono): Expose runtime-specific SDK options - #25290
Merged
Merged
Conversation
Co-Authored-By: Codex <codex@openai.com>
nicohrubec
marked this pull request as ready for review
October 12, 2026 13:45
nicohrubec
requested review from
chargome,
mydea and
s1gr1d
and removed request for
a team
October 12, 2026 13:45
chargome
approved these changes
Oct 12, 2026
nicohrubec
pushed a commit
that referenced
this pull request
Oct 12, 2026
Backport of: #25290 ## Differences to the original PR - `packages/hono/test/{bun,cloudflare,deno}/middleware.test.ts`, `packages/hono/test/node/sdk.test.ts`: the option-forwarding tests use `skipOpenTelemetrySetup` instead of `enableOpenTelemetrySetup`. `enableOpenTelemetrySetup` is a v11-only option, and v10's runtime option types (`OpenTelemetryServerRuntimeOptions`, `DenoOptions`, `CloudflareOptions`) expose `skipOpenTelemetrySetup` instead. The values were inverted to keep the same meaning (`enable: true` -> `skip: false`, `enable: false` -> `skip: true`). The source changes are the same as in the original PR. <!-- junior-request-attribution:start --> via Junior system actor `junior`. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:agent-dispatch%3Adispatch_b29cfc0ab8f95b9fb7084e4e1bd2fd8e --> -- [View Junior Session](https://junior-prod.sentry.dev/conversations/agent-dispatch%3Adispatch_b29cfc0ab8f95b9fb7084e4e1bd2fd8e) [[Sentry]](https://sentry.sentry.io/explore/conversations/agent-dispatch%3Adispatch_b29cfc0ab8f95b9fb7084e4e1bd2fd8e/?project=4510944073809921) <!-- junior-session-footer:end --> Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hono forwards SDK options to each runtime SDK, but its public types only expose core options. This makes TypeScript reject supported settings such as
enableOpenTelemetrySetup, Node transport options, and Cloudflare RPC bindings.Inherit the Node, Bun, Deno, and Cloudflare option types while retaining Hono's middleware options. Extend the existing option-preservation tests to check that these settings compile and are forwarded.