Repository navigation
test(node): Await the child exit in the "should exit" integration tests - #25277
Merged
Merged
Conversation
JPeer264
added this pull request to stack #25283
October 12, 2026 12:19
JPeer264
marked this pull request as ready for review
October 12, 2026 12:23
JPeer264
requested review from
mydea and
nicohrubec
and removed request for
a team
October 12, 2026 12:23
nicohrubec
approved these changes
Oct 12, 2026
JPeer264
force-pushed
the
jp/flaky-node-should-exit
branch
from
October 12, 2026 12:33
3022308 to
9f7475f
Compare
JPeer264
removed this pull request from stack #25283
October 13, 2026 15:29
JPeer264
added this pull request to stack #25335
October 13, 2026 15:29
The thread-blocked-native tests waited a fixed 5 seconds and then checked that the child process had exited. Under load in CI the child sometimes needs longer, so the test failed. The ANR tests polled every 100 ms. The runner now has `exited()`, which resolves on the child's `close` event. Both suites await it, and the describe timeout still fails a child that never exits. `childHasExited()` had no other users and is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JPeer264
force-pushed
the
jp/flaky-node-should-exit
branch
from
October 13, 2026 15:36
9f7475f to
cfbd5f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
exited()to the integration test runner. It resolves on thecloseevent of the child process. The four "should exit" tests inthread-blocked-nativeandanrnow await it. Before,thread-blocked-nativewaited a fixed 5 s, andanrchecked every 100 ms.childHasExited()had no other users and is removed.Why
Under CI load the child process sometimes needed more than 5 s to exit, so the test failed although the process exited correctly. The describe timeout still fails a child that never exits.
Failed on CI: https://github.com/getsentry/sentry-javascript/actions/runs/38031718055/job/114154033567