Repository navigation
fix(v10/node): Don't mark fetch spans as errors when the caller aborts - #25273
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
andreiborza
approved these changes
Oct 12, 2026
andreiborza
marked this pull request as ready for review
October 12, 2026 13:51
andreiborza
requested review from
msonnb and
stephanie-anderson
and removed request for
a team and
stephanie-anderson
October 12, 2026 13:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #25129
Differences to the original PR
packages/node-core/src/integrations/node-fetch/undici-instrumentation.ts. On v10 the vendored undici instrumentation is in@sentry/node-core, not@sentry/node. TheonErrorchange itself is the same.// eslint-disable-next-line typescript/no-deprecatedabove theerror.code === DOMException.ABORT_ERRcheck. Without it, v10'stypescript/no-deprecatedlint rule fails onDOMException.code. Runtime behavior does not change.packages/node-core/test/integrations/undici.test.ts. v10 has noundici.test.tsto extend. The new file uses the same mock setup as the develop test file (@sentry/corestartInactiveSpan/getClient,outgoingFetchRequest) and contains only the newrequest errorscases. It leaves out the existing develop-only QUERY-method/span-naming tests.via Junior system actor
junior.--
View Junior Session [Sentry]