Repository navigation
fix(nuxt): Delete public source maps before Nitro lists its public assets - #25267
Merged
Merged
Conversation
s1gr1d
requested review from
mydea and
nicohrubec
and removed request for
a team
October 12, 2026 11:17
Member
Author
|
bugbot run |
JPeer264
approved these changes
Oct 12, 2026
| const rollupConfig = (nitro.options.rollupConfig ??= { output: {} }); | ||
|
|
||
| rollupConfig.plugins = [ | ||
| rollupConfig.plugins, |
Member
There was a problem hiding this comment.
q: don't we have to spread it? Or is it automatically flattened?
Suggested change
| rollupConfig.plugins, | |
| ...rollupConfig.plugins, |
Member
Author
There was a problem hiding this comment.
that's not needed as rollup and rolldown flatten nested plugin arrays
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f44da22. Configure here.
This was referenced Oct 12, 2026
47 tasks done
3 tasks done
s1gr1d
added a commit
that referenced
this pull request
Oct 13, 2026
This is a copy of `nuxt-4-sourcemaps` for Nuxt 5 (Nitro 3), set up like `nuxt-5`: it uses the nightly builds and runs as an optional app. It differs from the Nuxt 4 test in two places: - **No intermediate client build:** Nuxt 5 writes the client build straight into `.output/public`. So the check that every client debug ID was uploaded runs only when the maps are kept. - **Existing Nuxt 5 bugs:** three assertions are skipped with TODOs, one for each bug: - The server maps have no `sourcesContent`. - Files with glob characters in the path are not uploaded. - The server maps do not reach the `.vue` files. Merge after this is merged: #25267 and #25287 (CI fix)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nitro lists the files in its public dir when it bundles the server. The SDK deleted the client source maps later, in
close, so requests for them returned 500 instead of 404.Now a plugin on Nitro's build deletes them in
buildStart. It deletes only matching files in the public dir. Other matches, like server maps, are still deleted inclose: the default glob also matches the SSR build's maps, which Nitro needs during its build.Fixes #25242