Repository navigation
fix(sveltekit): Read load event pathname untracked - #25235
Merged
Merged
Conversation
The load wrappers read event.url.pathname for the url.path attribute outside of untrack, so SvelteKit marked every wrapped load as depending on the URL and reran it on each navigation. Read the pathname through untrack, or the native URL getter when untrack is unavailable. Fixes #25231 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
bugbot run |
…ation Covers #25231 in a real app: a wrapped layout server load that doesn't read url must not rerun when navigating between its child pages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d66cf2b. Configure here.
Contributor
size-limit report 📦
|
chargome
marked this pull request as ready for review
October 12, 2026 09:34
chargome
requested review from
Lms24,
nicohrubec and
s1gr1d
and removed request for
a team
October 12, 2026 09:34
s1gr1d
reviewed
Oct 12, 2026
| [SENTRY_ORIGIN]: 'auto.function.sveltekit', | ||
| [SENTRY_SEGMENT_NAME_SOURCE]: routeId ? 'route' : 'url', | ||
| [URL_PATH]: event.url.pathname, | ||
| [URL_PATH]: pathname, |
Member
There was a problem hiding this comment.
We should make sure that dataCollection.urlQueryParams is respected here as well.
Member
Author
There was a problem hiding this comment.
This should be fine as the path never contains query strings
s1gr1d
approved these changes
Oct 12, 2026
JPeer264
approved these changes
Oct 12, 2026
JPeer264
left a comment
JPeer264
left a comment
Member
There was a problem hiding this comment.
I'm too late, anyways. here a review:
| const routeId = getRouteId(event) ?? undefined; | ||
| const routeOrPathname = routeId ? routeId : event.url.pathname; | ||
| const pathname = getPathname(event); | ||
| const routeOrPathname = routeId ? routeId : pathname; |
Member
There was a problem hiding this comment.
super-l: Wouldn't this be the same?
Suggested change
| const routeOrPathname = routeId ? routeId : pathname; | |
| const routeOrPathname = routeId || pathname; |
47 tasks done
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
url.pathattribute added in #24341 made the load wrappers readevent.url.pathnameoutsideuntrack. SvelteKit took that as the load depending on the URL, so every wrapped load reran on each navigation. With auto-instrumentation on, that's every load in the app.The pathname is now read through
event.untrack, the same waygetRouteIdalready readsroute.id. On SvelteKit 2 versions that don't haveuntrackyet, it calls the nativeURL.prototypegetter instead. SvelteKit's tracking getter is an own property onevent.url, so the native getter skips it.Fixes #25231