Repository navigation
feat(nextjs): Never emit trace meta tags from a prerender #25141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1b068ed
feat(nextjs): Never emit trace meta tags from a prerender
chargome 9394a8b
test(nextjs): Skip the ISR meta tag assertions in every dev variant
chargome edf0d98
fix(nextjs): Key the prerender trace guard on the OpenTelemetry context
chargome 408c7cc
fix(nextjs): Also recognize a prerender span that is activated by its…
chargome 5b173c4
fix(nextjs): Apply the prerender trace guard to `withSentry` on Cloud…
chargome fe3af83
test(nextjs): Cover an ISR page that is prerendered again at runtime
chargome dd8445b
docs(nextjs): Shorten the changelog entry
chargome 0ab39be
docs(nextjs): Reword the changelog entry
chargome 2c8bb46
docs(nextjs): Write the changelog entry in the Important Changes format
chargome dd54af4
ref(nextjs): Split the prerender context marking out of the propagato…
chargome a2aeaf5
test(nextjs): Skip the prerendered ISR tests from one describe block
chargome d4fcbc3
docs(nextjs): Drop the internals wording from the changelog entry
chargome c0c0993
feat(nextjs): Export the prerender guard for custom OpenTelemetry setups
chargome 89d0ecc
docs(nextjs): Simplify the changelog entry
chargome f0e687f
test(nextjs): Skip the prerendered ISR assertions on vinext
chargome 6651191
docs(nextjs): Keep the changelog entry under Unreleased after the rebase
chargome File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 3 additions & 2 deletions
5
.../test-applications/nextjs-16-cacheComponents/tests/cacheOrigin-pageloadConnection.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 3 additions & 2 deletions
5
...ications/nextjs-16-streaming-cacheComponents/tests/cacheOrigin-pageloadConnection.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
dev-packages/e2e-tests/test-applications/nextjs-16/app/isr-test/runtime/page.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| // A short revalidation window, so a test can make the server prerender this page again at runtime. | ||
| export const revalidate = 1; | ||
|
|
||
| export default function ISRRuntimePage() { | ||
| return ( | ||
| <div> | ||
| <h1>ISR Runtime Page</h1> | ||
| <div id="isr-runtime-rendered-at">{Date.now()}</div> | ||
| </div> | ||
| ); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.