Repository navigation
fix(nestjs): trace WebSocket interceptor contexts - #24862
faizansaiyed123 wants to merge 1 commit into
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
d2bd884 to
4bca084
Compare
4bca084 to
89f0658
Compare
b5cdddd to
ef6a094
Compare
|
👋 @nicohrubec, @s1gr1d — Please review this PR when you get a chance! |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 16ee4bc. Configure here.
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Hey @faizansaiyed123 thanks for opening a PR!
This PR currently has a massive amount of changes. I think it may need a rebase so that we can see what the intended changes are here.
|
@Lms24 Thanks for the review! Agreed — the branch history has accumulated a large number of upstream commits, which makes the PR difficult to review. I’ll rebase the branch onto the latest |
629eec6 to
d073e4e
Compare
6a59f5c to
5353fe6
Compare
|
👋 @nicohrubec, @s1gr1d — Please review this PR when you get a chance! |
|
👋 @mydea, @Lms24, @andreiborza — Please review this PR when you get a chance! |
|
👋 @nicohrubec, @s1gr1d — Please review this PR when you get a chance! |
|
👋 @mydea, @Lms24, @andreiborza — Please review this PR when you get a chance! |
|
👋 @nicohrubec, @s1gr1d — Please review this PR when you get a chance! |
This branch has not been deployed
2 participants
Extends the existing NestJS tracing interceptor to name WebSocket transactions from the WebSocket pattern, including the Socket.IO namespace when available. Non-Socket.IO adapters fall back to the pattern alone, and contexts without a pattern keep the existing pass-through behavior.
Regression tests cover Socket.IO namespaces, namespace-less adapters, and missing patterns.
Fixes #13810