Repository navigation
Conversation
📲 Install BuildsAndroid
|
f1d130d to
0d800c3
Compare
runningcode
left a comment
runningcode
left a comment
There was a problem hiding this comment.
LGTM! Great cleanup!
| } | ||
| } | ||
|
|
||
| apiValidation { |
There was a problem hiding this comment.
where was this consumed? was it the root plugin alias(libs.plugins.binary.compatibility.validator) ?
| val kotlin = project.extensions.getByName("kotlin") as ExtensionAware | ||
| val spec: AbiValidationVariantSpec = | ||
| when (val abi = kotlin.extensions.getByName("abiValidation")) { | ||
| is AbiValidationMultiplatformExtension -> abi.also { it.enabled.set(true) } |
There was a problem hiding this comment.
sad we can't do this. i bet we could though if this was a .kts file. and just FYI you can write these convention plugins in kts
| is AbiValidationMultiplatformExtension -> abi.also { it.enabled.set(true) } | |
| is AbiValidationMultiplatformExtension -> abi.enabled.set(true) } |
| } | ||
| // Lazy, because the module configures the extension after this plugin has been applied. | ||
| val ignored = extension.ignoredPackages.map { packages -> packages.map { "$it.**" } } | ||
| spec.filters { exclude { byNames.addAll(ignored) } } |
There was a problem hiding this comment.
can you move this up to line 48 like so?
filters { exclude { byNames.addAll(....) } }
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 92ae73f. Configure here.
Co-Authored-By: Markus Hintersteiner <markus.hintersteiner@sentry.io>
📜 Description
The Binary Compatibility Validator plugin is in maintenance mode, and superseded by the built-in ABI validation feature of the Kotlin Gradle Plugin.
Luckily the resulting
.apifiles stayed identical, so the diff is relatively easy.Also deleted two stale
.apifiles from sample apps along the way.💡 Motivation and Context
Groundwork for Gradle Isolated Projects feature, which the Binary Compatibility Validator plugin does not support (see Kotlin/binary-compatibility-validator#298).
💚 How did you test it?
Manually, deleted all
.apifiles, regenerated them.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#skip-changelog