Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1472 to v7. Fixes #1466 for the 7.x line.
configureUtilityProcessIPC()replacedchild.onwith a Proxy that registered an anonymous wrapper around eachmessagelistener to hide the SDK's handshake message.offandremoveListenercompare by identity and never found the wrapper, so listeners were never removed.oncebroke the same way because Node'soncecallson, so its wrapper was wrapped again and never removed itself.addListenerandprependListenerwere not wrapped and received the handshake message.The wrapping now covers all five add methods and each wrapper carries a
listenerproperty pointing at the caller's function. Node'sremoveListenerandlisteners()look through that property, sooffandlisteners()work without proxying them.onceregisters a wrapper that removes itself on the first message that is not hidden.Clean cherry-pick apart from one import conflict. Unit tests and the issue's script pass against the v7 build; the utility process e2e tests pass.