Repository navigation
fix: Only add main process context lines to renderer frames in the app directory - #1469
Merged
Merged
Conversation
Renderer stack frames hold renderer URLs, not paths in the main process filesystem. The main process ContextLines integration now skips events that come from renderers.
Preload script frames are files in the app directory and need main process context lines. Renderer frames outside the app directory still get none.
timfish
changed the title
timfish
enabled auto-merge (squash)
October 15, 2026 11:33
JPeer264
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renderer stack frames mostly hold renderer URLs, which the main process
ContextLinesintegration cannot resolve. Preload script frames are the exception: they are files in the app directory, and the main process adds context lines to them.This marks events from renderers in
sdkProcessingMetadataand wraps theContextLinesintegration. For renderer events, it only adds context lines to frames whose file is insideapp.getAppPath(). Main process and utility process events are not changed. The wrapper also applies when users addcontextLinesIntegrationthemselves.The marker uses
sdkProcessingMetadata, so it is not sent to Sentry.