Skip to content

chore: Enable type-aware linting #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timfish merged 1 commit into from
May 19, 2026
Merged

chore: Enable type-aware linting #1373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
"es2017": true,
"node": true
},
"options": {
"typeAware": true
},
"ignorePatterns": [
"**/dist/**",
"/esm/**",
Expand Down Expand Up @@ -80,7 +83,9 @@
"no-unsafe-optional-chaining": "off",
"max-lines": "off",
"vitest/no-conditional-tests": "off",
"typescript/no-explicit-any": "off"
"typescript/no-explicit-any": "off",
"typescript/no-floating-promises": "off",
"typescript/no-unsafe-member-access": "off"
}
}
]
Expand Down
7 changes: 4 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,10 @@
"prelint": "yarn set-version",
"lint": "run-s lint:oxfmt lint:oxlint",
"lint:oxfmt": "oxfmt --check \"{scripts,src,test,examples}/**/*.{ts,js}\"",
"lint:oxlint": "oxlint .",
"lint:oxlint": "OXLINT_TSGOLINT_DANGEROUSLY_SUPPRESS_PROGRAM_DIAGNOSTICS=true oxlint . ",
"fix": "run-s fix:oxfmt fix:oxlint",
"fix:oxfmt": "oxfmt --write \"{scripts,src,test,examples}/**/*.{ts,js}\"",
"fix:oxlint": "oxlint . --fix",
"fix:oxlint": "OXLINT_TSGOLINT_DANGEROUSLY_SUPPRESS_PROGRAM_DIAGNOSTICS=true oxlint . --fix",
Comment thread
timfish marked this conversation as resolved.
"update-electron-versions": "node ./scripts/update-electron-versions.mjs",
"update-sdk-versions": "node ./scripts/update-sdk-versions.mjs",
"pretest": "yarn set-version",
Expand Down Expand Up @@ -133,7 +133,8 @@
"koa-tree-router": "^0.12.1",
"npm-run-all2": "^8.0.4",
"oxfmt": "^0.32.0",
"oxlint": "^1.50.0",
"oxlint": "1.53.0",
"oxlint-tsgolint": "^0.23.0",
"rimraf": "^6.0.1",
"rollup": "^4.44.1",
"tmp": "^0.2.1",
Expand Down
2 changes: 1 addition & 1 deletion src/main/header-injection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ function addHeader(
value: string,
): Electron.HeadersReceivedResponse {
if (responseHeaders[name]) {
const existing = responseHeaders[name] as string | string[];
const existing = responseHeaders[name];

if (Array.isArray(existing)) {
existing.push(value);
Expand Down
2 changes: 1 addition & 1 deletion src/main/integrations/electron-breadcrumbs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ export const electronBreadcrumbsIntegration = defineIntegration(
emitter: NodeJS.EventEmitter | WebContents | BrowserWindow,
category: string,
shouldCapture: EventFunction | undefined | false,
id?: number | undefined,
id?: number,
): void {
const emit = emitter.emit.bind(emitter) as (event: string, ...args: unknown[]) => boolean;

Expand Down
2 changes: 1 addition & 1 deletion src/main/integrations/net-breadcrumbs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ function createWrappedRequestFactory(
return function wrappedRequestMethodFactory(originalRequestMethod: RequestMethod): RequestMethod {
return function requestMethod(this: typeof electronNet, reqOptions: RequestOptions): ClientRequest {
const { url, method } = parseOptions(reqOptions);
const request = originalRequestMethod.apply(this, [reqOptions]) as ClientRequest;
const request = originalRequestMethod.apply(this, [reqOptions]);

if (url.match(/sentry_key/) || request.getHeader('x-sentry-auth')) {
return request;
Expand Down
6 changes: 3 additions & 3 deletions src/main/sessions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export function startSession(sendOnCreate: boolean): void {
persistTimer = setInterval(async () => {
const currentSession = getIsolationScope().getSession();
// Only bother saving if it hasn't already ended
if (currentSession && currentSession.status === 'ok') {
if (currentSession?.status === 'ok') {
await getSessionStore().set(makeSessionSafeToSerialize(currentSession));
}
}, PERSIST_INTERVAL_MS);
Expand Down Expand Up @@ -161,7 +161,7 @@ export async function previousSessionWasAbnormal(): Promise<void> {
environment: (previous as unknown as SerializedSession).attrs?.environment,
});

await client.sendSession(sesh);
client.sendSession(sesh);

previousSession = undefined;
}
Expand Down Expand Up @@ -193,7 +193,7 @@ export async function checkPreviousSession(crashed: boolean): Promise<void> {
environment: (previous as unknown as SerializedSession).attrs?.environment,
});

await client.sendSession(sesh);
client.sendSession(sesh);

previousSession = undefined;
}
Expand Down
44 changes: 43 additions & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,6 +518,36 @@
resolved "https://registry.yarnpkg.com/@oxfmt/binding-win32-x64-msvc/-/binding-win32-x64-msvc-0.32.0.tgz#9e22eebbb6f0be9e5a6dc8e2c96e491b01d7cdf1"
integrity sha512-fF8VIOeligq+mA6KfKvWtFRXbf0EFy73TdR6ZnNejdJRM8VWN1e3QFhYgIwD7O8jBrQsd7EJbUpkAr/YlUOokg==

"@oxlint-tsgolint/darwin-arm64@0.23.0":
version "0.23.0"
resolved "https://registry.yarnpkg.com/@oxlint-tsgolint/darwin-arm64/-/darwin-arm64-0.23.0.tgz#96fa2e0cdda617cb5955bcfd4eddeec4867185fd"
integrity sha512-gOs9PVr2wEg4ox9z0aJo+RKhhImW86YL5N6yav8BK/rgPsIrwN/igSZ+pbRr723NFvUNKde9fgMhRA6JrXAOZw==

"@oxlint-tsgolint/darwin-x64@0.23.0":
version "0.23.0"
resolved "https://registry.yarnpkg.com/@oxlint-tsgolint/darwin-x64/-/darwin-x64-0.23.0.tgz#d44981462462ef51b40ba6a07ca0a24a78e335fd"
integrity sha512-kjJ8B+7n4tB9VJdxS5A9GdJt6/bYpzbu4lXp2uO1S3sRmCB5gDEABlGoiePNApRWaW+xqL4b4xgiE727jSLhuA==

"@oxlint-tsgolint/linux-arm64@0.23.0":
version "0.23.0"
resolved "https://registry.yarnpkg.com/@oxlint-tsgolint/linux-arm64/-/linux-arm64-0.23.0.tgz#60b18468500133b06c7e2600d641967a4db40b17"
integrity sha512-6dCZuKNu135seMXilkRk9SpCx6i1XgmiipYGalLij5WVRX6ZYS8c4xI7preN/zv9fCXhsQclTIMDu2Y/cytTjw==

"@oxlint-tsgolint/linux-x64@0.23.0":
version "0.23.0"
resolved "https://registry.yarnpkg.com/@oxlint-tsgolint/linux-x64/-/linux-x64-0.23.0.tgz#f8d677a37fd3bd3540504316471732b089509b89"
integrity sha512-3bdilnyA7kmSTjK27rvjIjSxL5SIg3wt7vwNiRkouWB83ytssyKnuGvxSYJxgMEmFpSutzaBzcCUM2jDtPGcgA==

"@oxlint-tsgolint/win32-arm64@0.23.0":
version "0.23.0"
resolved "https://registry.yarnpkg.com/@oxlint-tsgolint/win32-arm64/-/win32-arm64-0.23.0.tgz#c5e602d3776296f157a5c7ffa49b0ab7246560cb"
integrity sha512-j+OEp44SVYiQ+ZD+uttsX7u6L9SvmbbQ77SO1pSFCcJlsVMeCk8qZsjhKfGKuT/jIA+ipOJMVs/+pqUfObBWNw==

"@oxlint-tsgolint/win32-x64@0.23.0":
version "0.23.0"
resolved "https://registry.yarnpkg.com/@oxlint-tsgolint/win32-x64/-/win32-x64-0.23.0.tgz#a1f1b60f33a786077d209c568bf33a884114c5ea"
integrity sha512-5MyjFuqf+g8OUPJBSGWHJtmoWnzFJYyOg4To9WMQshZYEWig/vtu7JtJ03VWnzHv9LJkAUeApY0gVCOywFR/iQ==

"@oxlint/binding-android-arm-eabi@1.53.0":
version "1.53.0"
resolved "https://registry.yarnpkg.com/@oxlint/binding-android-arm-eabi/-/binding-android-arm-eabi-1.53.0.tgz#c42286b0a96d31fedc7b37183518c9e4054f6330"
Expand Down Expand Up @@ -2159,7 +2189,19 @@ oxfmt@^0.32.0:
"@oxfmt/binding-win32-ia32-msvc" "0.32.0"
"@oxfmt/binding-win32-x64-msvc" "0.32.0"

oxlint@^1.50.0:
oxlint-tsgolint@^0.23.0:
version "0.23.0"
resolved "https://registry.yarnpkg.com/oxlint-tsgolint/-/oxlint-tsgolint-0.23.0.tgz#bcbfbae3ada9c515229f9d33962ed609a3c98ffa"
integrity sha512-3mBv3CoPbh8dFbzfDGIWa2ytZjn2v+3EX4aKRXjIhsoGFzG8GCjfRirz3rwZf1wYbZzsNLTSgpw8VjQuWdp/jA==
optionalDependencies:
"@oxlint-tsgolint/darwin-arm64" "0.23.0"
"@oxlint-tsgolint/darwin-x64" "0.23.0"
"@oxlint-tsgolint/linux-arm64" "0.23.0"
"@oxlint-tsgolint/linux-x64" "0.23.0"
"@oxlint-tsgolint/win32-arm64" "0.23.0"
"@oxlint-tsgolint/win32-x64" "0.23.0"

oxlint@1.53.0:
version "1.53.0"
resolved "https://registry.yarnpkg.com/oxlint/-/oxlint-1.53.0.tgz#74b2241c639501b68574550578869055a28f9ee6"
integrity sha512-TLW0PzGbpO1JxUnuy1pIqVPjQUGh4fNfxu5XJbdFIRFVaJ0UFzTjjk/hSFTMRxN6lZub53xL/IwJNEkrh7VtDg==
Expand Down
Loading