Repository navigation
feat(descriptions): AWS Lambda function descriptions - #720
pabloDeputter wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8032d1a. Configure here.
Lms24
left a comment
There was a problem hiding this comment.
This should be okay, given that (for better or worse) JS doesn't set the request method and route parameters. If we did set it, it would break our existing descriptions which users could filter/alert/build dashboards on.
That being said, I think its fine to include this information in the description, as that makes it more ... descriptive 😅
|
Thanks! Yeah for now python doesn't set it as well, but it will be added in 3.0 and added in the migration guide 👌 |

Description
Describes HTTP-triggered
function.awsspans by the function and the route:{{faas.name}} {{http.request.method}} {{http.route}}, e.g.checkout GET /orders/{id}.function.azurekeeps its previous template as a separate description.Why
Previously, the description was the function name, the same as the span name, so every HTTP route showed as
function.aws checkoutin the trace waterfall.