Skip to content

feat(attributes): Add AWS Lambda, Step Functions and Secrets Manager name attributes - #716

Open
pabloDeputter wants to merge 1 commit into
mainfrom
pablo/aws-resource-name-attributes
Open

pabloDeputter wants to merge 1 commit into
mainfrom
pablo/aws-resource-name-attributes

Conversation

@pabloDeputter

@pabloDeputter pabloDeputter commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Description

Adds the following attributes (non-OTel):

  • aws.lambda.function.name: the function a Lambda API call acts on (GetFunction, UpdateFunctionCode, …)
  • aws.step_functions.state_machine.name
  • aws.step_functions.activity.name
  • aws.secretsmanager.secret.name: from the Name Secrets Manager returns

Why

Next PR (#717) in stack adds descriptions for AWS SDK spans by service, operation and resource, e.g. SecretsManager.GetSecretValue db-password. Other services already have a short name for this (aws.s3.bucket, aws.kinesis.stream_name, faas.invoked_name). These only had the full ARN, e.g. arn:aws:secretsmanager:us-east-1:123456789012:secret:db-password-AbCdEf, which is too long and already in the respective ARN attribute.

All of these resource names are already part of the ARNs we collect, so no new data is sent.

…name attributes

Add `aws.lambda.function.name`, `aws.step_functions.state_machine.name`, `aws.step_functions.activity.name` and `aws.secretsmanager.secret.name`.
@vercel

vercel Bot commented Oct 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sentry-conventions Ready Ready Preview Oct 14, 2026 1:12pm UTC

Request Review

@github-actions

Copy link
Copy Markdown

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Add AWS Lambda, Step Functions and Secrets Manager name attributes by pabloDeputter in #716
  • Add http.request.duration by loewenheim in #697

Bug Fixes 🐛

  • (attributes) Apply consistent scrubbing across deprecations by mjq in #692

Internal Changes 🔧

  • (repo) Update CODEOWNERS to include @giortzisg by Lms24 in #708

🤖 This preview updates automatically when you update the PR.

@pabloDeputter
pabloDeputter added this pull request to stack #718 October 14, 2026 13:24
@pabloDeputter
pabloDeputter marked this pull request as ready for review October 14, 2026 13:44

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2f60aee. Configure here.

* Type for {@link _AWS_LAMBDA_FUNCTION_NAME} aws.lambda.function_name
*/
export type AWS_LAMBDA_FUNCTION_NAME_TYPE = string;
export type _AWS_LAMBDA_FUNCTION_NAME_TYPE = string;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lambda constant rebound to new key

High Severity

aws.lambda.function.name normalizes to the same public constant as the existing aws.lambda.function_name key. AWS_LAMBDA_FUNCTION_NAME now means the new SDK-target name, and the old key moves to _AWS_LAMBDA_FUNCTION_NAME. Callers keep compiling but record a different attribute, and the Python deprecation warning no longer fires for the old identifier. These keys are not aliases: the old one still aliases faas.name.

Additional Locations (2)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2f60aee. Configure here.

This branch was successfully deployed

1 active deployment
Preview — 2f60aee3 Deployed Oct 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant