Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion javascript/sentry-conventions/src/attributes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33840,7 +33840,15 @@ export const ATTRIBUTE_METADATA: Record<AttributeName, AttributeMetadata> = {
isInOtel: true,
visibility: 'public',
example: 'myService.BestService',
changelog: [{ version: '0.1.0', prs: [127] }, { version: '0.0.0' }],
changelog: [
{ version: 'next', prs: [714], description: 'Added additional context about the OpenTelemetry deprecation' },
{ version: '0.1.0', prs: [127] },
{ version: '0.0.0' },
],
additionalContext: [
'Deprecated in OpenTelemetry for generic RPC spans. The value should be included in `rpc.method`, which is expected to be the fully-qualified name.',
'Still set on AWS SDK spans, where it holds the AWS service (e.g. `S3`) and `rpc.method` is set to the operation (e.g. `GetObject`).',
],
},
'rpc.system': {
brief: 'A string identifying the remoting system.',
Expand Down
9 changes: 9 additions & 0 deletions model/attributes/rpc/rpc__service.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,19 @@
"apply_scrubbing": {
"key": "manual"
},
"additional_context": [
"Deprecated in OpenTelemetry for generic RPC spans. The value should be included in `rpc.method`, which is expected to be the fully-qualified name.",
"Still set on AWS SDK spans, where it holds the AWS service (e.g. `S3`) and `rpc.method` is set to the operation (e.g. `GetObject`)."
],
"is_in_otel": true,
"example": "myService.BestService",
"visibility": "public",
"changelog": [
{
"version": "next",
"prs": [714],
"description": "Added additional context about the OpenTelemetry deprecation"
},
{
"version": "0.1.0",
"prs": [127]
Expand Down
14 changes: 14 additions & 0 deletions model/name/rpc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"brief": "RPC",
"operations": [
{
"name": "RPC call",
"brief": "A remote procedure call, such as an AWS SDK call or a gRPC call. The first template only applies to AWS SDK calls: `rpc.service` is deprecated for other RPC systems following OpenTelemetry, so they fallback to `{rpc.method}`.",
"is_in_otel": true,
"otel_notes": "OpenTelemetry names RPC spans `{rpc.method}`, falling back to `{rpc.system.name}` if `rpc.method` is unavailable or set to `_OTHER`. AWS SDK spans are named `{rpc.service}.{rpc.method}`, which the first template matches.",
"ops": ["rpc"],
"templates": ["{{rpc.service}}.{{rpc.method}}", "{{rpc.method}}", "{{rpc.system.name}}", "RPC call"],
Comment thread
cursor[bot] marked this conversation as resolved.
"examples": ["S3.ListBuckets", "Lambda.Invoke", "com.example.ExampleService/exampleMethod", "grpc", "RPC call"]
}
]
}
9 changes: 9 additions & 0 deletions python/src/sentry_conventions/attributes.py
Original file line number Diff line number Diff line change
Expand Up @@ -25507,9 +25507,18 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
visibility=Visibility.PUBLIC,
example="myService.BestService",
changelog=[
ChangelogEntry(
version="next",
prs=[714],
description="Added additional context about the OpenTelemetry deprecation",
),
ChangelogEntry(version="0.1.0", prs=[127]),
ChangelogEntry(version="0.0.0"),
],
additional_context=[
"Deprecated in OpenTelemetry for generic RPC spans. The value should be included in `rpc.method`, which is expected to be the fully-qualified name.",
"Still set on AWS SDK spans, where it holds the AWS service (e.g. `S3`) and `rpc.method` is set to the operation (e.g. `GetObject`).",
],
),
"rpc.system": AttributeMetadata(
brief="A string identifying the remoting system.",
Expand Down
Loading